[GitHub] [airflow] kurtqq commented on a change in pull request #17399: Adding JWT, IP filtering, and direct session login support for SalesforceHook

[GitBox <gi...@apache.org>]

kurtqq commented on a change in pull request #17399:
URL: https://github.com/apache/airflow/pull/17399#discussion_r682077772



##########
File path: airflow/providers/salesforce/hooks/salesforce.py
##########
@@ -74,6 +91,29 @@ def get_connection_form_widgets() -> Dict[str, Any]:
                 lazy_gettext("Security Token"), widget=BS3PasswordFieldWidget()
             ),
             "extra__salesforce__domain": StringField(lazy_gettext("Domain"), widget=BS3TextFieldWidget()),
+            "extra__salesforce__consumer_key": StringField(
+                lazy_gettext("Consumer Key"), widget=BS3TextFieldWidget()
+            ),
+            "extra__salesforce__private_key_file_path": PasswordField(
+                lazy_gettext("Private Key File Path"), widget=BS3PasswordFieldWidget()
+            ),
+            "extra__salesforce__private_key": PasswordField(
+                lazy_gettext("Private Key"), widget=BS3PasswordFieldWidget()
+            ),
+            "extra__salesforce__organization_id": StringField(
+                lazy_gettext("Organization ID"), widget=BS3TextFieldWidget()
+            ),
+            "extra__salesforce__instance": StringField(lazy_gettext("Instance"), widget=BS3TextFieldWidget()),
+            "extra__salesforce__instance_url": StringField(
+                lazy_gettext("Instance URL"), widget=BS3TextFieldWidget()
+            ),
+            "extra__salesforce__proxies": StringField(lazy_gettext("Proxies"), widget=BS3TextFieldWidget()),
+            "extra__salesforce__version": StringField(
+                lazy_gettext("Salesforce API Version"), widget=BS3TextFieldWidget()

Review comment:
       ```suggestion
                   lazy_gettext("API Version"), widget=BS3TextFieldWidget()
   ```
   This is salesforce connection, just calling it api version is enough i believe




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org