[GitHub] [hudi] danny0405 commented on a diff in pull request #7490: [HUDI-5407][HUDI-5408] Fixing rollback in MDT to be eager

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #7490:
URL: https://github.com/apache/hudi/pull/7490#discussion_r1084833971


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackActionExecutor.java:
##########
@@ -155,12 +156,13 @@ private void validateRollbackCommitSequence() {
     // since with LAZY rollback we support parallel writing which can allow a new inflight while rollback is ongoing
     // Remove this once we support LAZY rollback of failed writes by default as parallel writing becomes the default
     // writer mode.
-    if (config.getFailedWritesCleanPolicy().isEager()) {
+    if (config.getFailedWritesCleanPolicy().isEager()  && !HoodieTableMetadata.isMetadataTable(config.getBasePath())) {

Review Comment:
   So we just loosen restrictions for MDT rollback check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org