You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/12 16:27:43 UTC
[GitHub] [spark] viirya opened a new pull request #30017: [SPARK-25271][SQL][2.4] Hive ctas commands should use data source if it is convertible
viirya opened a new pull request #30017:
URL: https://github.com/apache/spark/pull/30017
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
In Spark 2.3.0 and previous versions, Hive CTAS command will convert to use data source to write data into the table when the table is convertible. This behavior is controlled by the configs like HiveUtils.CONVERT_METASTORE_ORC and HiveUtils.CONVERT_METASTORE_PARQUET.
In 2.3.1, we drop this optimization by mistake in the PR [SPARK-22977](https://github.com/apache/spark/pull/20521/files#r217254430). Since that Hive CTAS command only uses Hive Serde to write data.
This patch adds this optimization back to Hive CTAS command. This patch adds OptimizedCreateHiveTableAsSelectCommand which uses data source to write data.
This is to backport #22514 to branch-2.4.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
This bug was originally reported in 2.3.1, but only fixed in 3.0. We should have it in branch-2.4 because the branch is LTS.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. Users can use the config to use built-in data source writer instead of Hive serde in CTAS.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30017: [SPARK-25271][SQL][2.4] Hive ctas commands should use data source if it is convertible
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30017:
URL: https://github.com/apache/spark/pull/30017#issuecomment-707239790
cc @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30017: [SPARK-25271][SQL][2.4] Hive ctas commands should use data source if it is convertible
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30017:
URL: https://github.com/apache/spark/pull/30017#issuecomment-707221573
cc @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30017: [SPARK-25271][SQL][2.4] Hive ctas commands should use data source if it is convertible
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30017:
URL: https://github.com/apache/spark/pull/30017#issuecomment-707221578
**[Test build #129698 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129698/testReport)** for PR 30017 at commit [`e3ffaaf`](https://github.com/apache/spark/commit/e3ffaaf63cf467c351cac24b9f0eaa1b63f308c2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30017: [SPARK-25271][SQL][2.4] Hive ctas commands should use data source if it is convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30017:
URL: https://github.com/apache/spark/pull/30017#issuecomment-707237445
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30017: [SPARK-25271][SQL][2.4] Hive ctas commands should use data source if it is convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30017:
URL: https://github.com/apache/spark/pull/30017#issuecomment-707309278
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30017: [SPARK-25271][SQL][2.4] Hive ctas commands should use data source if it is convertible
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30017:
URL: https://github.com/apache/spark/pull/30017#issuecomment-707233230
cc @anuragmantri
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30017: [SPARK-25271][SQL][2.4] Hive ctas commands should use data source if it is convertible
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30017:
URL: https://github.com/apache/spark/pull/30017#issuecomment-707347588
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30017: [SPARK-25271][SQL][2.4] Hive ctas commands should use data source if it is convertible
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30017:
URL: https://github.com/apache/spark/pull/30017#issuecomment-707221578
**[Test build #129698 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129698/testReport)** for PR 30017 at commit [`e3ffaaf`](https://github.com/apache/spark/commit/e3ffaaf63cf467c351cac24b9f0eaa1b63f308c2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30017: [SPARK-25271][SQL][2.4] Hive ctas commands should use data source if it is convertible
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30017:
URL: https://github.com/apache/spark/pull/30017#issuecomment-707308803
**[Test build #129698 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129698/testReport)** for PR 30017 at commit [`e3ffaaf`](https://github.com/apache/spark/commit/e3ffaaf63cf467c351cac24b9f0eaa1b63f308c2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `trait CreateHiveTableAsSelectBase extends DataWritingCommand `
* `case class CreateHiveTableAsSelectCommand(`
* `case class OptimizedCreateHiveTableAsSelectCommand(`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30017: [SPARK-25271][SQL][2.4] Hive ctas commands should use data source if it is convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30017:
URL: https://github.com/apache/spark/pull/30017#issuecomment-707309278
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30017: [SPARK-25271][SQL][2.4] Hive ctas commands should use data source if it is convertible
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30017:
URL: https://github.com/apache/spark/pull/30017#issuecomment-707232227
Thank you, @viirya .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30017: [SPARK-25271][SQL][2.4] Hive ctas commands should use data source if it is convertible
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30017:
URL: https://github.com/apache/spark/pull/30017#issuecomment-707231289
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34304/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30017: [SPARK-25271][SQL][2.4] Hive ctas commands should use data source if it is convertible
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30017:
URL: https://github.com/apache/spark/pull/30017#issuecomment-707237445
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30017: [SPARK-25271][SQL][2.4] Hive ctas commands should use data source if it is convertible
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30017:
URL: https://github.com/apache/spark/pull/30017
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30017: [SPARK-25271][SQL][2.4] Hive ctas commands should use data source if it is convertible
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30017:
URL: https://github.com/apache/spark/pull/30017#issuecomment-707237406
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34304/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org