You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2020/04/09 09:25:54 UTC
[commons-numbers] branch master updated (f3bab83 -> 424c6c3)
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git.
from f3bab83 FractionException: Removed unused exception constant.
new c8e4fe2 BigFraction: Document exception thrown by reciprocal when zero.
new ded2840 Fraction: Add zero test to equals and hashCode
new 58aafe1 BigFraction: Correct javadoc for pow(double) method.
new 424c6c3 Fraction: Add thrown exception to pow javadoc.
The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../org/apache/commons/numbers/fraction/BigFraction.java | 13 ++++++++++---
.../java/org/apache/commons/numbers/fraction/Fraction.java | 1 +
.../apache/commons/numbers/fraction/BigFractionTest.java | 2 +-
.../org/apache/commons/numbers/fraction/FractionTest.java | 7 ++++++-
4 files changed, 18 insertions(+), 5 deletions(-)
[commons-numbers] 01/04: BigFraction: Document exception thrown by
reciprocal when zero.
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit c8e4fe25bbdb08ecb23643bde3f3ac55d0926156
Author: aherbert <ah...@apache.org>
AuthorDate: Thu Apr 9 09:46:20 2020 +0100
BigFraction: Document exception thrown by reciprocal when zero.
---
.../main/java/org/apache/commons/numbers/fraction/BigFraction.java | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java b/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java
index d0411f0..541fb6c 100644
--- a/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java
+++ b/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java
@@ -521,6 +521,13 @@ public final class BigFraction
return new BigFraction(numerator.negate(), denominator);
}
+ /**
+ * {@inheritDoc}
+ *
+ * <p>Raises an exception if the fraction is equal to zero.
+ *
+ * @throws ArithmeticException if the current numerator is {@code zero}
+ */
@Override
public BigFraction reciprocal() {
return new BigFraction(denominator, numerator);
[commons-numbers] 03/04: BigFraction: Correct javadoc for
pow(double) method.
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit 58aafe135561b2912ec0301655dc431e796175dc
Author: aherbert <ah...@apache.org>
AuthorDate: Thu Apr 9 10:18:08 2020 +0100
BigFraction: Correct javadoc for pow(double) method.
---
.../main/java/org/apache/commons/numbers/fraction/BigFraction.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java b/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java
index 541fb6c..a4a14a4 100644
--- a/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java
+++ b/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java
@@ -954,11 +954,11 @@ public final class BigFraction
}
/**
- * Returns a {@code BigFraction} whose value is
- * <code>this<sup>exponent</sup></code>, returning the result in reduced form.
+ * Returns a {@code double} whose value is
+ * <code>this<sup>exponent</sup></code>.
*
* @param exponent exponent to which this {@code BigFraction} is to be raised.
- * @return <code>this<sup>exponent</sup></code>.
+ * @return <code>this<sup>exponent</sup></code> as a {@code double}.
*/
public double pow(final double exponent) {
return Math.pow(numerator.doubleValue(), exponent) /
[commons-numbers] 04/04: Fraction: Add thrown exception to pow
javadoc.
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit 424c6c359b230554acf29afebf6c375e12b84d1d
Author: aherbert <ah...@apache.org>
AuthorDate: Thu Apr 9 10:22:21 2020 +0100
Fraction: Add thrown exception to pow javadoc.
Add test to the demonstrate exception due to overflow.
---
.../src/main/java/org/apache/commons/numbers/fraction/Fraction.java | 1 +
.../test/java/org/apache/commons/numbers/fraction/FractionTest.java | 5 +++++
2 files changed, 6 insertions(+)
diff --git a/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java b/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java
index 8f41989..fa7b377 100644
--- a/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java
+++ b/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java
@@ -642,6 +642,7 @@ public final class Fraction
*
* @param exponent exponent to which this {@code Fraction} is to be raised.
* @return <code>this<sup>exponent</sup></code>.
+ * @throws ArithmeticException if the intermediate result would overflow.
*/
@Override
public Fraction pow(final int exponent) {
diff --git a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
index 082b884..2a5d5f1 100644
--- a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
+++ b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
@@ -376,6 +376,11 @@ public class FractionTest {
Fraction c = Fraction.of(0, -11);
assertFraction(0, -1, c.pow(Integer.MAX_VALUE));
+
+ Assertions.assertThrows(ArithmeticException.class, () -> Fraction.of(Integer.MAX_VALUE).pow(2));
+ Assertions.assertThrows(ArithmeticException.class, () -> Fraction.of(1, Integer.MAX_VALUE).pow(2));
+ Assertions.assertThrows(ArithmeticException.class, () -> Fraction.of(Integer.MAX_VALUE).pow(-2));
+ Assertions.assertThrows(ArithmeticException.class, () -> Fraction.of(1, Integer.MAX_VALUE).pow(-2));
}
@Test
[commons-numbers] 02/04: Fraction: Add zero test to equals and
hashCode
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit ded284061692853f2e1bffec71ef7ce600a5246a
Author: aherbert <ah...@apache.org>
AuthorDate: Thu Apr 9 09:52:19 2020 +0100
Fraction: Add zero test to equals and hashCode
---
.../test/java/org/apache/commons/numbers/fraction/BigFractionTest.java | 2 +-
.../src/test/java/org/apache/commons/numbers/fraction/FractionTest.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java
index b0ae45f..dfb104e 100644
--- a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java
+++ b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/BigFractionTest.java
@@ -591,7 +591,7 @@ public class BigFractionTest {
// Test using different representations of the same fraction
// (Denominators are primes)
- for (int[] f : new int[][] {{1, 1}, {2, 3}, {6826, 15373}, {1373, 103813}}) {
+ for (int[] f : new int[][] {{1, 1}, {2, 3}, {6826, 15373}, {1373, 103813}, {0, 3}}) {
final int num = f[0];
final int den = f[1];
BigFraction f1 = BigFraction.of(-num, den);
diff --git a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
index 718ca34..082b884 100644
--- a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
+++ b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
@@ -450,7 +450,7 @@ public class FractionTest {
// Test using different representations of the same fraction
// (Denominators are primes)
- for (int[] f : new int[][] {{1, 1}, {2, 3}, {6826, 15373}, {1373, 103813}}) {
+ for (int[] f : new int[][] {{1, 1}, {2, 3}, {6826, 15373}, {1373, 103813}, {0, 3}}) {
final int num = f[0];
final int den = f[1];
Fraction f1 = Fraction.of(-num, den);