You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Sijie Guo (JIRA)" <ji...@apache.org> on 2012/11/12 13:41:12 UTC
[jira] [Created] (BOOKKEEPER-463) Refactor garbage collection code
for ease to plugin different GC algorithm.
Sijie Guo created BOOKKEEPER-463:
------------------------------------
Summary: Refactor garbage collection code for ease to plugin different GC algorithm.
Key: BOOKKEEPER-463
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
Project: Bookkeeper
Issue Type: Sub-task
Reporter: Sijie Guo
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-463) Refactor garbage collection
code for ease to plugin different GC algorithm.
Posted by "Fangmin Lv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501665#comment-13501665 ]
Fangmin Lv commented on BOOKKEEPER-463:
---------------------------------------
@Yixue
Thanks for your command, I have reupload the diff file.
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-463.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-463) Refactor garbage collection code
for ease to plugin different GC algorithm.
Posted by "Fangmin Lv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fangmin Lv updated BOOKKEEPER-463:
----------------------------------
Attachment: BOOKKEEPER-463.patch
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-463) Refactor garbage collection code
for ease to plugin different GC algorithm.
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-463:
---------------------------------
Fix Version/s: (was: 4.3.0)
4.2.0
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-463) Refactor garbage collection
code for ease to plugin different GC algorithm.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507176#comment-13507176 ]
Hadoop QA commented on BOOKKEEPER-463:
--------------------------------------
Testing JIRA BOOKKEEPER-463
WARNING: Running test-patch on a dirty local svn workspace
Patch <a href="/jira/secure/attachment/12555476/BOOKKEEPER-463.patch">/jira/secure/attachment/12555476/BOOKKEEPER-463.patch</a> downloaded at Fri Nov 30 07:30:35 UTC 2012
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:red}-1{color} the patch contains 1 line(s) with trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than 120
. {color:green}+1{color} the patch does adds/modifies 3 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
. {color:red}WARNING: the current HEAD has Findbugs warning(s), they should be addressed ASAP{color}
{color:green}+1 TESTS{color}
. Tests run: 383
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/55/
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-463) Refactor garbage collection
code for ease to plugin different GC algorithm.
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508462#comment-13508462 ]
Sijie Guo commented on BOOKKEEPER-463:
--------------------------------------
After this jira, I would generate the documentation patches for both bookkeeper and hedwig's metadata manager.
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-463) Refactor garbage collection code
for ease to plugin different GC algorithm.
Posted by "Fangmin Lv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fangmin Lv updated BOOKKEEPER-463:
----------------------------------
Attachment: BOOKKEEPER-463.patch
Fix empty global active ledgers scenario.
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-463) Refactor garbage collection
code for ease to plugin different GC algorithm.
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505156#comment-13505156 ]
Sijie Guo commented on BOOKKEEPER-463:
--------------------------------------
I would suggest this jira should go for 4.2.0, since I think it introduced a cleaner interface for the implementation of LedgerManager. we need to provide documentation of LedgerManager for BookKeeper and MetadataManager for Hedwig in BOOKKEEPER-341 and BOOKKEEPER-342 before rolling out 4.2.0 release, it would be a good idea to provide a cleaner interface for 4.2.0.
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-463) Refactor garbage collection code
for ease to plugin different GC algorithm.
Posted by "Fangmin Lv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fangmin Lv updated BOOKKEEPER-463:
----------------------------------
Assignee: Fangmin Lv
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.2.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-463) Refactor garbage collection code
for ease to plugin different GC algorithm.
Posted by "Fangmin Lv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fangmin Lv updated BOOKKEEPER-463:
----------------------------------
Attachment: BOOKKEEPER-463.patch
Reattach a file, changes:
1. Correct comments about ScanAndCompareGarbageCollector
2. Throw NoSuchElementException if have no more elements when call next.
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-463) Refactor garbage collection
code for ease to plugin different GC algorithm.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510929#comment-13510929 ]
Hadoop QA commented on BOOKKEEPER-463:
--------------------------------------
Testing JIRA BOOKKEEPER-463
Patch [BOOKKEEPER-463.patch|https://issues.apache.org/jira/secure/attachment/12556086/BOOKKEEPER-463.patch] downloaded at Wed Dec 5 23:22:15 UTC 2012
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than 120
. {color:green}+1{color} the patch does adds/modifies 3 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
{color:green}+1 TESTS{color}
. Tests run: 393
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/75/
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-463) Refactor garbage collection code
for ease to plugin different GC algorithm.
Posted by "Fangmin Lv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fangmin Lv updated BOOKKEEPER-463:
----------------------------------
Attachment: BOOKKEEPER-463.patch
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-463.patch, BOOKKEEPER-463.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-463) Refactor garbage collection
code for ease to plugin different GC algorithm.
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508461#comment-13508461 ]
Sijie Guo commented on BOOKKEEPER-463:
--------------------------------------
I think this refactor could be done in 4.2.0 to provide a cleaner ledger manager interface. so I marked this jira to 4.2.0. [~fpj][~ikelly] could any of you take a look at Fangmin's patch on https://reviews.apache.org/r/8141/ ?
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-463) Refactor garbage collection code
for ease to plugin different GC algorithm.
Posted by "Fangmin Lv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fangmin Lv updated BOOKKEEPER-463:
----------------------------------
Attachment: BOOKKEEPER-463.patch
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-463) Refactor garbage collection code
for ease to plugin different GC algorithm.
Posted by "Fangmin Lv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fangmin Lv updated BOOKKEEPER-463:
----------------------------------
Attachment: BOOKKEEPER-463.patch
Upload a new patch to remove:
1.unused SnapshotMap in AbstractZKLedgerManager
2.trailing spaces
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-463) Refactor garbage collection
code for ease to plugin different GC algorithm.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504534#comment-13504534 ]
Hadoop QA commented on BOOKKEEPER-463:
--------------------------------------
Testing JIRA BOOKKEEPER-463
WARNING: Running test-patch on a dirty local svn workspace
Patch <a href="/jira/secure/attachment/12554448/BOOKKEEPER-463.patch">/jira/secure/attachment/12554448/BOOKKEEPER-463.patch</a> downloaded at Tue Nov 27 10:43:23 UTC 2012
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:red}-1{color} the patch contains 1 line(s) longer than 120 characters
. {color:green}+1{color} the patch does adds/modifies 3 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
. {color:red}WARNING{color}: the current HEAD has 8 Javadoc warning(s)
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac warnings
. {color:red}WARNING{color}: the current HEAD has 9 javac warning(s)
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
. {color:red}WARNING: the current HEAD has Findbugs warning(s), they should be addressed ASAP{color}
{color:green}+1 TESTS{color}
. Tests run: 389
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/23/
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-463) Refactor garbage collection code
for ease to plugin different GC algorithm.
Posted by "Fangmin Lv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fangmin Lv updated BOOKKEEPER-463:
----------------------------------
Attachment: BOOKKEEPER-463.patch
Attach a patch to implement this, main changes:
1. Refactor Garbage Collector Interface
2. Change LedgerManager#deleteLedger to versioned delete
3. Remove ActiveLedgerManager interface
4. Move some common functions to StringUtils and ZkUtils
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-463.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-463) Refactor garbage collection
code for ease to plugin different GC algorithm.
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504368#comment-13504368 ]
Sijie Guo commented on BOOKKEEPER-463:
--------------------------------------
[~lvfangmin] The patch looks good. I had some minor comments, mostly about naming and interface. I posted them on review board. please check.
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-463) Refactor garbage collection code
for ease to plugin different GC algorithm.
Posted by "Fangmin Lv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fangmin Lv updated BOOKKEEPER-463:
----------------------------------
Fix Version/s: (was: 4.2.0)
4.3.0
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-463) Refactor garbage collection
code for ease to plugin different GC algorithm.
Posted by "Fangmin Lv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504380#comment-13504380 ]
Fangmin Lv commented on BOOKKEEPER-463:
---------------------------------------
Thanks sijie, I will reply on the code review board and change the name according to your advice.
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-463) Refactor garbage collection code
for ease to plugin different GC algorithm.
Posted by "Fangmin Lv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fangmin Lv updated BOOKKEEPER-463:
----------------------------------
Attachment: BOOKKEEPER-463.patch
Provide a new patch according to Sijie and Flavio's suggestion.
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-463) Refactor garbage collection
code for ease to plugin different GC algorithm.
Posted by "Yixue (Andrew) Zhu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501295#comment-13501295 ]
Yixue (Andrew) Zhu commented on BOOKKEEPER-463:
-----------------------------------------------
The patch to 'bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollector.java' didn't apply cleanly.
> Refactor garbage collection code for ease to plugin different GC algorithm.
> ---------------------------------------------------------------------------
>
> Key: BOOKKEEPER-463
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-463.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira