You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/06 15:26:06 UTC

[GitHub] [kafka] mjsax commented on a change in pull request #10640: KAFKA-10847: Set StreamsConfig on InternalTopologyDriver before writing topology

mjsax commented on a change in pull request #10640:
URL: https://github.com/apache/kafka/pull/10640#discussion_r627522997



##########
File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java
##########
@@ -290,6 +290,10 @@ public void buildAndOptimizeTopology(final Properties props) {
             }
 
             if (streamGraphNode.allParentsWrittenToTopology() && !streamGraphNode.hasWrittenToTopology()) {
+                if (props != null && !props.isEmpty()) {
+                    internalTopologyBuilder.setStreamsConfig(new StreamsConfig(props));

Review comment:
       I think we should unify this can call this method only once.
   
   Why not just call it with `KafkaStreams` constructor?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org