You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/05/31 13:49:22 UTC
[GitHub] flink pull request #4032: [Proposal] Gradually introduce checkstyle into fli...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4032
[Proposal] Gradually introduce checkstyle into flink-runtime
This is a proposal on how to activate the strict checkstyle in flink-runtime.
We can't add the rules to all packages at once due to the generally accepted problem of massive merge-conflicts this would cause with current feature branches. However, we can also not we apply the rules one by one due to the sheer number of merge conflicts this would entail for a single rebase, as @greghogan note in #4027.
Instead i propose to activate the full checkstyle one package at a time.
The first commit in this PR adds the maven checkstyle plugin to flink-runtime, and adds an exclusion for every single 2nd level package (e.g "runtime/accumulators") that currently exists.
The second commit activates the checkstyle for `runtime/accumulators`, but resolving all issues and removing the exclusion.
The list of exclusions gives us a nice overview over our current progress regarding the checkstyle introduction, provides an easy way to parallelize the work, and automatically covers any new module that is being added.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6729csrun
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4032.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4032
----
commit a295537935c919e1be7d6362a77d48c624e7fd57
Author: zentol <ch...@apache.org>
Date: 2017-05-31T13:37:15Z
Add checkstyle plugin to flink-runtime pom
commit 2d0215fddbecfd6fffd28a0bfa8bb4e2061b8aaa
Author: zentol <ch...@apache.org>
Date: 2017-05-31T13:40:34Z
Activate checkstyle in /runtime/accumulators
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4032: [Proposal] Gradually introduce checkstyle into flink-runt...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4032
+1 very nice! Also, once other modules are complete we can move the "strict checkstyle" to be just the "checkstyle" while this work is finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4032: [Proposal] Gradually introduce checkstyle into flink-runt...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4032
ok, then I'll merge this PR as is. I'll make a sweep through the existing packages to see for which ones we can activate it right away.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4032: [Proposal] Gradually introduce checkstyle into flink-runt...
Posted by NicoK <gi...@git.apache.org>.
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4032
nice - on the way to finally getting a more consistent codebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4032: [Proposal] Gradually introduce checkstyle into fli...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4032
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4032: [Proposal] Gradually introduce checkstyle into flink-runt...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4032
Ha! this idea is quite nice. I like how it automatically applies to newly created packages.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---