You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/06/18 11:08:10 UTC
[GitHub] [submarine] pingsutw opened a new pull request #315: SUBMARINE-527. [SDK] Abstract client API
pingsutw opened a new pull request #315:
URL: https://github.com/apache/submarine/pull/315
### What is this PR for?
Try to simplify client API that generated by swagger, we could add an abstract layer on swagger API, and let users more easily submit experiments
Before: [Jupyter example](https://github.com/pingsutw/hadoop-submarine/blob/SUBMARINE-516/submarine-sdk/pysubmarine/example/submarine_experiment_sdk.ipynb)
After: [Jupyter example](https://github.com/pingsutw/hadoop-submarine/blob/SUBMARINE-527/submarine-sdk/pysubmarine/example/submarine_experiment_sdk.ipynb)
### What type of PR is it?
[Improvement]
### Todos
* [ ] - e2e test
* [ ] - unit test
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-527?jql=project%20%3D%20SUBMARINE#
### How should this be tested?
https://travis-ci.org/github/pingsutw/hadoop-submarine/builds/699648185
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on pull request #315: SUBMARINE-527. [SDK] Abstract client API
Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #315:
URL: https://github.com/apache/submarine/pull/315#issuecomment-646463163
@tangzhankun I've add `wait_for_finish`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] tangzhankun commented on pull request #315: SUBMARINE-527. [SDK] Abstract client API
Posted by GitBox <gi...@apache.org>.
tangzhankun commented on pull request #315:
URL: https://github.com/apache/submarine/pull/315#issuecomment-646004269
@pingsutw Thanks for the update! The "list experiment log by status" might have bugs in it? Need confirmation from @jiwq
For the API, can we add a wait_for_finish(id) method which gets logs periodically until the experiment finish?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] tangzhankun edited a comment on pull request #315: SUBMARINE-527. [SDK] Abstract client API
Posted by GitBox <gi...@apache.org>.
tangzhankun edited a comment on pull request #315:
URL: https://github.com/apache/submarine/pull/315#issuecomment-646514440
@pingsutw Thanks for the contribution. Committed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #315: SUBMARINE-527. [SDK] Abstract client API
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #315:
URL: https://github.com/apache/submarine/pull/315
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] tangzhankun commented on pull request #315: SUBMARINE-527. [SDK] Abstract client API
Posted by GitBox <gi...@apache.org>.
tangzhankun commented on pull request #315:
URL: https://github.com/apache/submarine/pull/315#issuecomment-646514440
@pingsutw Thanks for the contribution. Committed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on pull request #315: SUBMARINE-527. [SDK] Abstract client API
Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #315:
URL: https://github.com/apache/submarine/pull/315#issuecomment-645957822
I found that `list_log` only output **podName**, and **podLog** always is NULL.
Should we change to `list_podsName`?
https://github.com/apache/submarine/blob/0f281cad18ed5c1549b1286a9358a1eceba5991e/submarine-server/server-core/src/main/java/org/apache/submarine/server/rest/ExperimentRestApi.java#L180-L195
http://submarine:8080/api/v1/experiment/logs
output:
```json
{
"status": "OK",
"code": 200,
"success": true,
"message": null,
"result": [
{
"experimentId": "experiment_1592474530204_0001",
"logContent": [
{
"podName": "tf-mnist-json-ps-0",
"podLog": []
},
{
"podName": "tf-mnist-json-worker-0",
"podLog": []
}
]
}
],
"attributes": {}
}
```
/cc @jiwq @tangzhankun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] tangzhankun commented on pull request #315: SUBMARINE-527. [SDK] Abstract client API
Posted by GitBox <gi...@apache.org>.
tangzhankun commented on pull request #315:
URL: https://github.com/apache/submarine/pull/315#issuecomment-646502138
@pingsutw , thanks for the update! LGTM. Does the Travis failure relate to the PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on pull request #315: SUBMARINE-527. [SDK] Abstract client API
Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #315:
URL: https://github.com/apache/submarine/pull/315#issuecomment-646508893
it's unrelated to the PR, I've moved all testing to GitHub-action
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org