[GitHub] [phoenix] gjacoby126 commented on a diff in pull request #1686: PHOENIX-7003 Harden hbase region inconsistencies check in CQSI#getAllTableRegions method

["gjacoby126 (via GitHub)" <gi...@apache.org>]

gjacoby126 commented on code in PR #1686:
URL: https://github.com/apache/phoenix/pull/1686#discussion_r1334765885


##########
phoenix-core/src/test/java/org/apache/phoenix/query/ConnectionQueryServicesImplTest.java:
##########
@@ -194,7 +194,28 @@ public void testGetNextRegionStartKey() {
         GlobalClientMetrics.GLOBAL_HBASE_COUNTER_METADATA_INCONSISTENCY.getMetric().reset();
         when(mockHRegionInfo.getStartKey()).thenReturn(notCorruptedStartKey);
         when(mockHRegionInfo.getEndKey()).thenReturn(notCorruptedNewKey);
-        testGetNextRegionStartKey(mockCqsi, mockRegionLocation, notCorruptedEndKey, false);
+        testGetNextRegionStartKey(mockCqsi, mockRegionLocation, notCorruptedEndKey, true);

Review Comment:
   Why is isCorrupted true here if both start and endkey are not corrupt and the current endkey is greater than the previous end key?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org