You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2017/07/31 10:33:06 UTC

[GitHub] spark pull request #18778: [SPARK-21578][CORE] Add JavaSparkContextSuite

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18778#discussion_r130320047
  
    --- Diff: core/src/test/java/test/org/apache/spark/JavaSparkContextSuite.java ---
    @@ -0,0 +1,62 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package test.org.apache.spark;
    +
    +import java.io.*;
    +
    +import scala.collection.immutable.List;
    +import scala.collection.immutable.List$;
    +import scala.collection.immutable.Map;
    +import scala.collection.immutable.Map$;
    +
    +import org.junit.Test;
    +
    +import org.apache.spark.api.java.*;
    +import org.apache.spark.*;
    +
    +/**
    + * Java apps can uses both Java-friendly JavaSparkContext and Scala SparkContext.
    + */
    +public class JavaSparkContextSuite implements Serializable {
    +
    +  @Test
    +  public void javaSparkContext() {
    +    String[] jars = new String[] {};
    +    java.util.Map<String, String> environment = new java.util.HashMap<>();
    --- End diff --
    
    Nit: just import these classes as usual?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org