You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by bhavik patel <bh...@gmail.com> on 2021/12/10 10:23:07 UTC

Review Request 73753: RANGER-3543: Remove spotbugs-annotations-3.1.9 from classpath

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73753/
-----------------------------------------------------------

Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-3543
    https://issues.apache.org/jira/browse/RANGER-3543


Repository: ranger


Description
-------

Exclude/remove spotbugs-annotations-3.1.9 jar which is coming with Zookeeper dependency.


Diffs
-----

  kms/pom.xml 5f712ec92 
  security-admin/pom.xml 3e7a64f2a 


Diff: https://reviews.apache.org/r/73753/diff/1/


Testing
-------

spotbugs-annotations-3.1.9 jar is not present in Ranger class-path.


Thanks,

bhavik patel

Re: Review Request 73753: RANGER-3543: Remove spotbugs-annotations-3.1.9 from classpath

Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73753/#review223867
-----------------------------------------------------------



Pa


kms/pom.xml
Lines 437 (patched)
<https://reviews.apache.org/r/73753/#comment312906>

    Patch is not apply, please rebase.



security-admin/pom.xml
Lines 599 (patched)
<https://reviews.apache.org/r/73753/#comment312907>

    Patch has conflich , please rebase.


- Pradeep Agrawal


On Dec. 10, 2021, 10:23 a.m., bhavik patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73753/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2021, 10:23 a.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3543
>     https://issues.apache.org/jira/browse/RANGER-3543
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Exclude/remove spotbugs-annotations-3.1.9 jar which is coming with Zookeeper dependency.
> 
> 
> Diffs
> -----
> 
>   kms/pom.xml 5f712ec92 
>   security-admin/pom.xml 3e7a64f2a 
> 
> 
> Diff: https://reviews.apache.org/r/73753/diff/1/
> 
> 
> Testing
> -------
> 
> spotbugs-annotations-3.1.9 jar is not present in Ranger class-path.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 73753: RANGER-3543: Remove spotbugs-annotations-3.1.9 from classpath

Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73753/#review223866
-----------------------------------------------------------


Ship it!




Ship It!

- Pradeep Agrawal


On Dec. 10, 2021, 10:23 a.m., bhavik patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73753/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2021, 10:23 a.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3543
>     https://issues.apache.org/jira/browse/RANGER-3543
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Exclude/remove spotbugs-annotations-3.1.9 jar which is coming with Zookeeper dependency.
> 
> 
> Diffs
> -----
> 
>   kms/pom.xml 5f712ec92 
>   security-admin/pom.xml 3e7a64f2a 
> 
> 
> Diff: https://reviews.apache.org/r/73753/diff/1/
> 
> 
> Testing
> -------
> 
> spotbugs-annotations-3.1.9 jar is not present in Ranger class-path.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Re: Review Request 73753: RANGER-3543: Remove spotbugs-annotations-3.1.9 from classpath

Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73753/
-----------------------------------------------------------

(Updated Dec. 16, 2021, 10:01 a.m.)


Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

Rebased the patch.


Bugs: RANGER-3543
    https://issues.apache.org/jira/browse/RANGER-3543


Repository: ranger


Description
-------

Exclude/remove spotbugs-annotations-3.1.9 jar which is coming with Zookeeper dependency.


Diffs (updated)
-----

  kms/pom.xml 9e3639ef8 
  security-admin/pom.xml 6363a8c97 


Diff: https://reviews.apache.org/r/73753/diff/2/

Changes: https://reviews.apache.org/r/73753/diff/1-2/


Testing
-------

spotbugs-annotations-3.1.9 jar is not present in Ranger class-path.


Thanks,

bhavik patel