You are viewing a plain text version of this content. The canonical link for it is here.

Posted to xmlrpc-dev@ws.apache.org by Steve Quint <li...@nanohertz.com> on 2004/07/05 22:35:03 UTC

Re: PATCH: src/java/org/apache/xmlrpc/util/DateTool.java

At 11:54 PM -0700 6/29/04, Daniel L. Rall wrote:
>+1 on committing this patch to CVS HEAD (only).
>
>Steve, this is quite a bit of code.  Any chance of a JUnit test case 
>to go along with it?  It's the perfect sort of code for a unit test.
>
>Steve Quint wrote:
>>The current DateTool can only deal with one form of ISO 8601 dates 
>>- one that look like "yyyyMMddThh:mm:ss".  Any time zone 
>>information is discarded by the SimpleDateFormat object due to the 
>>format string.  Even worse, any other variant of ISO 8601 will 
>>cause the entire XMLRPC transaction to fail.

I actually do have test code for this.  I'll have to dig it up at home though.

What is the convention for integrating JUnit tests?  Since this 
project uses maven, is creating 
"src/test/org/apache/xmlrpc/util/DateToolTest.java" the "right" thing?
-- 

Steve

------------------------------------------------------------
"Always ... always remember: Less is less. More is more. More is
better. And twice as much is good too. Not enough is bad. And too
much is never enough except when it's just about right."
			-- The Tick
------------------------------------------------------------