Re: [PR] Unnest now works on MSQ (druid)

["somu-imply (via GitHub)" <gi...@apache.org>]

somu-imply commented on code in PR #14886:
URL: https://github.com/apache/druid/pull/14886#discussion_r1305781098


##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteArraysQueryTest.java:
##########
@@ -3930,6 +3945,8 @@ public void testUnnestWithJoinOnTheLeft()
   {
     skipVectorize();
     cannotVectorize();
+    notMsqCompatible();
+    // @todo check this back

Review Comment:
   There is a caveat here, the create segment map function of unnest will call the create segment map function of the base (which is Join with InputNumberDataSources). Now the joinableWrapper does not have info on InputNumberDataSource and will throw an exception `org.apache.druid.java.util.common.ISE: dataSource is not joinable: InputNumberDataSource{inputNumber=1}`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org