You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/17 00:28:19 UTC
[GitHub] [incubator-superset] pkdotson opened a new pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
pkdotson opened a new pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854
### SUMMARY
updates docs layout in mobile (text fits inside entire viewport), update links in docs and readme and other informational markdown files, and address css nits.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#issuecomment-692324923
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=h1) Report
> Merging [#10854](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/76275ec410d5021346a2fd366fed9739f8e7a625?el=desc) will **increase** coverage by `1.48%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10854 +/- ##
==========================================
+ Coverage 59.09% 60.57% +1.48%
==========================================
Files 776 380 -396
Lines 37040 24066 -12974
Branches 3309 0 -3309
==========================================
- Hits 21887 14579 -7308
+ Misses 14962 9487 -5475
+ Partials 191 0 -191
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #python | `60.57% <ø> (-0.77%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.85% <0.00%> (-11.44%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.66% <0.00%> (-1.67%)` | :arrow_down: |
| ... and [401 more](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=footer). Last update [76275ec...a2bfcaa](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#issuecomment-692324923
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=h1) Report
> Merging [#10854](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/af75bee582fb4f2964a78f2641980969af46a78b?el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10854 +/- ##
==========================================
- Coverage 65.79% 65.74% -0.05%
==========================================
Files 814 814
Lines 38316 38346 +30
Branches 3600 3590 -10
==========================================
+ Hits 25209 25211 +2
- Misses 13003 13031 +28
Partials 104 104
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `56.58% <ø> (-0.04%)` | :arrow_down: |
| #javascript | `61.72% <ø> (ø)` | |
| #python | `61.45% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `65.48% <0.00%> (-17.28%)` | :arrow_down: |
| [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `81.89% <0.00%> (-0.87%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.61% <0.00%> (-0.68%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `62.60% <0.00%> (ø)` | |
| [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=) | `70.21% <0.00%> (+1.32%)` | :arrow_up: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `93.65% <0.00%> (+1.58%)` | :arrow_up: |
| [...set-frontend/src/dashboard/util/getDashboardUrl.js](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZFVybC5qcw==) | `90.90% <0.00%> (+2.02%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=footer). Last update [af75bee...5727ba3](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#discussion_r488431524
##########
File path: docs/src/components/layout.tsx
##########
@@ -46,6 +47,23 @@ const layoutStyles = css`
border-color: #20a7c9;
border-radius: 4px;
}
+ .desktopView {
Review comment:
are these desktopView/mobileView/tabletView classes used somewhere?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#issuecomment-693687321
Looks like there are a couple of linting errors blocking CI, but some merged PRs should fix them. Rebasing this branch should solve it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#issuecomment-692324923
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=h1) Report
> Merging [#10854](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/af75bee582fb4f2964a78f2641980969af46a78b?el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10854 +/- ##
==========================================
- Coverage 65.79% 65.75% -0.04%
==========================================
Files 814 814
Lines 38316 38346 +30
Branches 3600 3590 -10
==========================================
+ Hits 25209 25214 +5
- Misses 13003 13028 +25
Partials 104 104
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `56.58% <ø> (-0.04%)` | :arrow_down: |
| #javascript | `61.72% <ø> (ø)` | |
| #python | `61.46% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `65.48% <0.00%> (-17.28%)` | :arrow_down: |
| [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `81.89% <0.00%> (-0.87%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `62.60% <0.00%> (ø)` | |
| [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=) | `70.21% <0.00%> (+1.32%)` | :arrow_up: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `93.65% <0.00%> (+1.58%)` | :arrow_up: |
| [...set-frontend/src/dashboard/util/getDashboardUrl.js](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZFVybC5qcw==) | `90.90% <0.00%> (+2.02%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=footer). Last update [af75bee...5727ba3](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#issuecomment-692324923
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=h1) Report
> Merging [#10854](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d4ee073bfe39ea723dcf36fef4e74e7c1767eec5?el=desc) will **increase** coverage by `1.72%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10854 +/- ##
==========================================
+ Coverage 59.73% 61.46% +1.72%
==========================================
Files 780 382 -398
Lines 37203 24123 -13080
Branches 3339 0 -3339
==========================================
- Hits 22224 14827 -7397
+ Misses 14795 9296 -5499
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #python | `61.46% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <0.00%> (-0.12%)` | :arrow_down: |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.80% <0.00%> (-0.07%)` | :arrow_down: |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | | |
| [...nd/src/dashboard/util/isInDifferentFilterScopes.js](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzSW5EaWZmZXJlbnRGaWx0ZXJTY29wZXMuanM=) | | |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | | |
| [...rc/explore/components/controls/TextAreaControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0QXJlYUNvbnRyb2wuanN4) | | |
| [...erset-frontend/src/SqlLab/components/SaveQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVRdWVyeS5qc3g=) | | |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | | |
| [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | | |
| [...perset-frontend/src/utils/getControlsForVizType.js](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENvbnRyb2xzRm9yVml6VHlwZS5qcw==) | | |
| ... and [392 more](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=footer). Last update [d4ee073...6981d02](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#discussion_r488423253
##########
File path: README.md
##########
@@ -71,24 +74,43 @@ A modern, enterprise-ready business intelligence web application.
## Why Superset
Superset provides:
-* An intuitive interface to explore and visualize datasets, and
- create interactive dashboards.
-* A wide array of beautiful visualizations to showcase your data.
-* Easy, code-free, user flows to drill down and slice and dice the data
- underlying exposed dashboards. The dashboards and charts act as a starting
- point for deeper analysis.
-* A state of the art SQL editor/IDE exposing a rich metadata browser, and
- an easy workflow to create visualizations out of any result set.
-* An extensible, high granularity security model allowing intricate rules
- on who can access which product features and datasets.
- Integration with major
- authentication backends (database, OpenID, LDAP, OAuth, REMOTE_USER, ...)
-* A lightweight semantic layer, allowing to control how data sources are
- exposed to the user by defining dimensions and metrics
-* Out of the box support for most SQL-speaking databases
-* Deep integration with Druid allows for Superset to stay blazing fast while
- slicing and dicing large, realtime datasets
-* Fast loading dashboards with configurable caching
+
+Viewed
+@@ -35,7 +35,7 @@ Superset
Review comment:
Is this code intentional? Looks like github copy/paste stuff
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#issuecomment-692324923
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=h1) Report
> Merging [#10854](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/76275ec410d5021346a2fd366fed9739f8e7a625?el=desc) will **increase** coverage by `1.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10854 +/- ##
==========================================
+ Coverage 59.09% 60.30% +1.21%
==========================================
Files 776 380 -396
Lines 37040 24075 -12965
Branches 3309 0 -3309
==========================================
- Hits 21887 14519 -7368
+ Misses 14962 9556 -5406
+ Partials 191 0 -191
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #python | `60.30% <ø> (-1.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.85% <0.00%> (-11.44%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `81.38% <0.00%> (-7.98%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [414 more](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=footer). Last update [76275ec...2a8ac41](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#discussion_r489948892
##########
File path: README.md
##########
@@ -71,24 +74,45 @@ A modern, enterprise-ready business intelligence web application.
## Why Superset
Superset provides:
-* An intuitive interface to explore and visualize datasets, and
- create interactive dashboards.
-* A wide array of beautiful visualizations to showcase your data.
-* Easy, code-free, user flows to drill down and slice and dice the data
- underlying exposed dashboards. The dashboards and charts act as a starting
- point for deeper analysis.
-* A state of the art SQL editor/IDE exposing a rich metadata browser, and
- an easy workflow to create visualizations out of any result set.
-* An extensible, high granularity security model allowing intricate rules
- on who can access which product features and datasets.
- Integration with major
- authentication backends (database, OpenID, LDAP, OAuth, REMOTE_USER, ...)
-* A lightweight semantic layer, allowing to control how data sources are
- exposed to the user by defining dimensions and metrics
-* Out of the box support for most SQL-speaking databases
-* Deep integration with Druid allows for Superset to stay blazing fast while
- slicing and dicing large, realtime datasets
-* Fast loading dashboards with configurable caching
+
+Viewed
+
+A modern, enterprise-ready business intelligence web application. Apache Superset (Incubating) is a modern,
+enterprise-ready business intelligence web application. It is fast, lightweight, intuitive,
+and loaded with options that make it easy for users of all skill sets to explore and visualize
+their data, from simple pie charts to highly detailed deck.gl geospatial charts.
Review comment:
actually i think this whole paragraph is duplicated from above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#issuecomment-692324923
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=h1) Report
> Merging [#10854](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/76275ec410d5021346a2fd366fed9739f8e7a625?el=desc) will **increase** coverage by `1.48%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10854 +/- ##
==========================================
+ Coverage 59.09% 60.57% +1.48%
==========================================
Files 776 380 -396
Lines 37040 24068 -12972
Branches 3309 0 -3309
==========================================
- Hits 21887 14580 -7307
+ Misses 14962 9488 -5474
+ Partials 191 0 -191
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #python | `60.57% <ø> (-0.77%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.85% <0.00%> (-11.44%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.66% <0.00%> (-1.67%)` | :arrow_down: |
| ... and [400 more](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=footer). Last update [76275ec...a2bfcaa](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#discussion_r489948128
##########
File path: README.md
##########
@@ -71,24 +74,45 @@ A modern, enterprise-ready business intelligence web application.
## Why Superset
Superset provides:
-* An intuitive interface to explore and visualize datasets, and
- create interactive dashboards.
-* A wide array of beautiful visualizations to showcase your data.
-* Easy, code-free, user flows to drill down and slice and dice the data
- underlying exposed dashboards. The dashboards and charts act as a starting
- point for deeper analysis.
-* A state of the art SQL editor/IDE exposing a rich metadata browser, and
- an easy workflow to create visualizations out of any result set.
-* An extensible, high granularity security model allowing intricate rules
- on who can access which product features and datasets.
- Integration with major
- authentication backends (database, OpenID, LDAP, OAuth, REMOTE_USER, ...)
-* A lightweight semantic layer, allowing to control how data sources are
- exposed to the user by defining dimensions and metrics
-* Out of the box support for most SQL-speaking databases
-* Deep integration with Druid allows for Superset to stay blazing fast while
- slicing and dicing large, realtime datasets
-* Fast loading dashboards with configurable caching
+
+Viewed
Review comment:
why does it say "Viewed" here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] pkdotson closed pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Posted by GitBox <gi...@apache.org>.
pkdotson closed pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#discussion_r488430978
##########
File path: docs/src/gatsby-theme-docz/index.tsx
##########
@@ -34,6 +34,10 @@ interface Props {
const docLayout = css`
display: flex;
flex-direction: row;
+ .docContainer {
+ word-wrap: break-all;
+ width: 100%;
Review comment:
Yep, this fixes the problem. I'll undo a flexbox change I was messing with, to the same effect, on another PR.
Note though, that with this div being 100%, and the `.anchorNavStyle` div being `position: fixed`, I'm pretty sure that the `.docLayout`'s `display: flex` and `flex-direction: row` styles have no effect/purpose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #10854: docs(style): fix navbar and docs for mobile as well as broken links
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#issuecomment-692254499
Most of this addressed in #10853 except for the broken link I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#discussion_r489947367
##########
File path: CONTRIBUTING.md
##########
@@ -299,31 +299,53 @@ cd incubator-superset
### Documentation
-The latest documentation and tutorial are available at https://superset.apache.org/.
+The latest documentation and tutorial are available at https://superset.apache.org/docs.
The site is written using the Gatsby framework and docz for the
documentation subsection. Find out more about it in `docs/README.md`
-#### Images
+The source for the docs can be fround in
+[/docs](https://github.com/apache/incubator-superset/tree/master/docs) subdirectory of the repository,
+and are written in the MDX format. [MDX]
+(https://storybook.js.org/docs/react/api/mdx) is basically Markdown with the ability to sprinkle in JSX code.
-If you're adding new images to the documentation, you'll notice that the images
-referenced in the rst, e.g.
+Rendering the docs is powered by [DocZ](https://www.docz.site/),
+which is built on top of [GatsbyJS](https://www.gatsbyjs.com/).
- .. image:: _static/images/tutorial/tutorial_01_sources_database.png
+#### DocZ Installation
-aren't actually stored in that directory. Instead, you should add and commit
-images (and any other static assets) to the `superset-frontend/images` directory.
-When the docs are deployed to https://superset.incubator.apache.org/, images
-are copied from there to the `_static/images` directory, just like they're referenced
-in the docs.
+First, `cd` into the `/docs` folder from `incubator-superset`:
-For example, the image referenced above actually lives in `superset-frontend/images/tutorial`. Since the image is moved during the documentation build process, the docs reference the image in `_static/images/tutorial` instead.
+```
+cd docs/
+```
+
+Then, install the Node packages that this project needs:
+
+```
+npm install
+```
+
+To start the server and render the docs, you need to run:
+
+```
+npm run develop
+```
+
+
+#### Making Changes to the Documentation
+
+Every time you make changes to files in the `/docs` repo, DocZ will automatically rebuild and serve the changes to you. If you make more complex changes, sometimes DocZ will serve a 404 page with an error. When that happens, you can run the following command to clean any built-up state:
+
+```
+npm run clean
+```
### Flask server
#### OS Dependencies
-Make sure your machine meets the [OS dependencies](https://superset.incubator.apache.org/installation.html#os-dependencies) before following these steps.
+Make sure your machine meets the [OS dependencies](https://superset.incubator.apache.org/docs/installation/installing-from -scratch) before following these steps.
Review comment:
there's an extra space in the link here...
but actually the OS dependencies are in another place https://superset.apache.org/docs/installation/installing-superset-from-scratch#os-dependencies
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#issuecomment-734494750
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] closed pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #10854: docs(style): fix navbar and docs for mobile as well as broken links
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#issuecomment-692174597
Let's merge this prior PR first that goes deeper into the navbar / mobile experience https://github.com/apache/incubator-superset/pull/10853
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#discussion_r488427225
##########
File path: docs/src/gatsby-theme-docz/index.tsx
##########
@@ -34,6 +34,10 @@ interface Props {
const docLayout = css`
display: flex;
flex-direction: row;
+ .docContainer {
+ word-wrap: break-all;
Review comment:
I think you mean `word-break: break-all;`, but that causes issues, with line-wraps mid-word.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#discussion_r488423373
##########
File path: README.md
##########
@@ -71,24 +74,43 @@ A modern, enterprise-ready business intelligence web application.
## Why Superset
Superset provides:
-* An intuitive interface to explore and visualize datasets, and
- create interactive dashboards.
-* A wide array of beautiful visualizations to showcase your data.
-* Easy, code-free, user flows to drill down and slice and dice the data
- underlying exposed dashboards. The dashboards and charts act as a starting
- point for deeper analysis.
-* A state of the art SQL editor/IDE exposing a rich metadata browser, and
- an easy workflow to create visualizations out of any result set.
-* An extensible, high granularity security model allowing intricate rules
- on who can access which product features and datasets.
- Integration with major
- authentication backends (database, OpenID, LDAP, OAuth, REMOTE_USER, ...)
-* A lightweight semantic layer, allowing to control how data sources are
- exposed to the user by defining dimensions and metrics
-* Out of the box support for most SQL-speaking databases
-* Deep integration with Druid allows for Superset to stay blazing fast while
- slicing and dicing large, realtime datasets
-* Fast loading dashboards with configurable caching
+
+Viewed
+@@ -35,7 +35,7 @@ Superset
+ width="500" width="500"
+/> />
+
+
+A modern, enterprise-ready business intelligence web application. Apache Superset (Incubating) is a modern, enterprise-ready business intelligence web application. It is fast, lightweight, intuitive, and loaded with options that make it easy for users of all skill sets to explore and visualize their data, from simple pie charts to highly detailed deck.gl geospatial charts.
+
+
+[**Why Superset**](#why-superset) | [**Why Superset**](#why-superset) |
+[**Supported Databases**](#supported-databases) | [**Supported Databases**](#supported-databases) |
+@@ -71,25 +71,27 @@ A modern, enterprise-ready business intelligence web application.
Review comment:
More github stuff, if I'm not mistaken
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#discussion_r489068228
##########
File path: README.md
##########
@@ -71,24 +74,45 @@ A modern, enterprise-ready business intelligence web application.
## Why Superset
Superset provides:
-* An intuitive interface to explore and visualize datasets, and
- create interactive dashboards.
-* A wide array of beautiful visualizations to showcase your data.
-* Easy, code-free, user flows to drill down and slice and dice the data
- underlying exposed dashboards. The dashboards and charts act as a starting
- point for deeper analysis.
-* A state of the art SQL editor/IDE exposing a rich metadata browser, and
- an easy workflow to create visualizations out of any result set.
-* An extensible, high granularity security model allowing intricate rules
- on who can access which product features and datasets.
- Integration with major
- authentication backends (database, OpenID, LDAP, OAuth, REMOTE_USER, ...)
-* A lightweight semantic layer, allowing to control how data sources are
- exposed to the user by defining dimensions and metrics
-* Out of the box support for most SQL-speaking databases
-* Deep integration with Druid allows for Superset to stay blazing fast while
- slicing and dicing large, realtime datasets
-* Fast loading dashboards with configurable caching
+
+Viewed
+
+A modern, enterprise-ready business intelligence web application. Apache Superset (Incubating) is a modern,
+enterprise-ready business intelligence web application. It is fast, lightweight, intuitive,
+and loaded with options that make it easy for users of all skill sets to explore and visualize
+their data, from simple pie charts to highly detailed deck.gl geospatial charts.
+
+[**Why Superset**](#why-superset) | [**Why Superset**](#why-superset) |
+[**Supported Databases**](#supported-databases) | [**Supported Databases**](#supported-databases) |
+
+## Why Superset ## Why Superset
Review comment:
this looks wrong
##########
File path: README.md
##########
@@ -71,24 +74,45 @@ A modern, enterprise-ready business intelligence web application.
## Why Superset
Superset provides:
-* An intuitive interface to explore and visualize datasets, and
- create interactive dashboards.
-* A wide array of beautiful visualizations to showcase your data.
-* Easy, code-free, user flows to drill down and slice and dice the data
- underlying exposed dashboards. The dashboards and charts act as a starting
- point for deeper analysis.
-* A state of the art SQL editor/IDE exposing a rich metadata browser, and
- an easy workflow to create visualizations out of any result set.
-* An extensible, high granularity security model allowing intricate rules
- on who can access which product features and datasets.
- Integration with major
- authentication backends (database, OpenID, LDAP, OAuth, REMOTE_USER, ...)
-* A lightweight semantic layer, allowing to control how data sources are
- exposed to the user by defining dimensions and metrics
-* Out of the box support for most SQL-speaking databases
-* Deep integration with Druid allows for Superset to stay blazing fast while
- slicing and dicing large, realtime datasets
-* Fast loading dashboards with configurable caching
+
+Viewed
+
+A modern, enterprise-ready business intelligence web application. Apache Superset (Incubating) is a modern,
+enterprise-ready business intelligence web application. It is fast, lightweight, intuitive,
+and loaded with options that make it easy for users of all skill sets to explore and visualize
+their data, from simple pie charts to highly detailed deck.gl geospatial charts.
+
+[**Why Superset**](#why-superset) | [**Why Superset**](#why-superset) |
+[**Supported Databases**](#supported-databases) | [**Supported Databases**](#supported-databases) |
+
+## Why Superset ## Why Superset
+
+Superset provides: Superset provides:
Review comment:
odd doubles, wondering what happened here. I highly recommend doing a first sanity pass on your PR when opening the PR on the step prior to "Create PR"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#issuecomment-692324923
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=h1) Report
> Merging [#10854](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/76275ec410d5021346a2fd366fed9739f8e7a625?el=desc) will **increase** coverage by `1.54%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10854 +/- ##
==========================================
+ Coverage 59.09% 60.63% +1.54%
==========================================
Files 776 380 -396
Lines 37040 24086 -12954
Branches 3309 0 -3309
==========================================
- Hits 21887 14605 -7282
+ Misses 14962 9481 -5481
+ Partials 191 0 -191
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #python | `60.63% <ø> (-0.72%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.85% <0.00%> (-11.44%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.74% <0.00%> (-1.60%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.26% <0.00%> (-0.42%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `88.03% <0.00%> (-0.28%)` | :arrow_down: |
| ... and [399 more](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=footer). Last update [76275ec...2a8ac41](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#issuecomment-692324923
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=h1) Report
> Merging [#10854](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d4ee073bfe39ea723dcf36fef4e74e7c1767eec5?el=desc) will **increase** coverage by `1.54%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10854 +/- ##
==========================================
+ Coverage 59.73% 61.27% +1.54%
==========================================
Files 780 382 -398
Lines 37203 24123 -13080
Branches 3339 0 -3339
==========================================
- Hits 22224 14782 -7442
+ Misses 14795 9341 -5454
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #python | `61.27% <ø> (-0.17%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.54% <0.00%> (-8.75%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.12% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.61% <0.00%> (-0.14%)` | :arrow_down: |
| [superset/tasks/alerts/validator.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL3ZhbGlkYXRvci5weQ==) | `95.23% <0.00%> (-0.12%)` | :arrow_down: |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `76.80% <0.00%> (-0.07%)` | :arrow_down: |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | | |
| [...uperset-frontend/src/components/PopoverSection.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUG9wb3ZlclNlY3Rpb24uanN4) | | |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | | |
| ... and [397 more](https://codecov.io/gh/apache/incubator-superset/pull/10854/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=footer). Last update [d4ee073...4522ed9](https://codecov.io/gh/apache/incubator-superset/pull/10854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#discussion_r488430978
##########
File path: docs/src/gatsby-theme-docz/index.tsx
##########
@@ -34,6 +34,10 @@ interface Props {
const docLayout = css`
display: flex;
flex-direction: row;
+ .docContainer {
+ word-wrap: break-all;
+ width: 100%;
Review comment:
Yep, this fixes the problem. I'll undo a flexbox change I was messing with, to the same effect, on another PR.
Note though, that with this div being 100%, and the `.anchorNavStyle` div being `position: fixed`, I'm pretty darn sure that the `docLayout`'s `display: flex` and `flex-direction: row` styles have no effect/purpose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#discussion_r489949866
##########
File path: README.md
##########
@@ -71,24 +74,45 @@ A modern, enterprise-ready business intelligence web application.
## Why Superset
Superset provides:
-* An intuitive interface to explore and visualize datasets, and
- create interactive dashboards.
-* A wide array of beautiful visualizations to showcase your data.
-* Easy, code-free, user flows to drill down and slice and dice the data
- underlying exposed dashboards. The dashboards and charts act as a starting
- point for deeper analysis.
-* A state of the art SQL editor/IDE exposing a rich metadata browser, and
- an easy workflow to create visualizations out of any result set.
-* An extensible, high granularity security model allowing intricate rules
- on who can access which product features and datasets.
- Integration with major
- authentication backends (database, OpenID, LDAP, OAuth, REMOTE_USER, ...)
-* A lightweight semantic layer, allowing to control how data sources are
- exposed to the user by defining dimensions and metrics
-* Out of the box support for most SQL-speaking databases
-* Deep integration with Druid allows for Superset to stay blazing fast while
- slicing and dicing large, realtime datasets
-* Fast loading dashboards with configurable caching
+
+Viewed
+
+A modern, enterprise-ready business intelligence web application. Apache Superset (Incubating) is a modern,
+enterprise-ready business intelligence web application. It is fast, lightweight, intuitive,
+and loaded with options that make it easy for users of all skill sets to explore and visualize
+their data, from simple pie charts to highly detailed deck.gl geospatial charts.
+
+[**Why Superset**](#why-superset) |
+[**Supported Databases**](#supported-databases) |
+
+## Why Superset
+
+Superset provides:
+- A rich set of data visualizations out of the box
+- An easy-to-use interface for exploring and visualizing data
+- The ability to easily create and share dashboards
+- Enterprise-ready authentication with integration with major authentication providers
+ (database, OpenID, LDAP, OAuth & REMOTE_USER through Flask AppBuilder)
+- An extensible, high-granularity security/permission model allowing intricate rules on who can access
+ individual features and the dataset
+- A simple semantic layer, allowing users to control how data sources are displayed in the UI by defining
+ which fields should show up in which drop-down and which aggregation and function metrics are made available to the user
+- Integration with most SQL-speaking RDBMS through SQLAlchemy
+- Deep integration with Druid.io
+
+Superset is cloud-native and designed to be highly available. It was designed to scale out to large,
Review comment:
wondering where these README updates are coming from, is that content that Kevin copied/wrote/recommended?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#discussion_r489947812
##########
File path: README.md
##########
@@ -71,24 +74,45 @@ A modern, enterprise-ready business intelligence web application.
## Why Superset
Superset provides:
-* An intuitive interface to explore and visualize datasets, and
- create interactive dashboards.
-* A wide array of beautiful visualizations to showcase your data.
-* Easy, code-free, user flows to drill down and slice and dice the data
- underlying exposed dashboards. The dashboards and charts act as a starting
- point for deeper analysis.
-* A state of the art SQL editor/IDE exposing a rich metadata browser, and
- an easy workflow to create visualizations out of any result set.
-* An extensible, high granularity security model allowing intricate rules
- on who can access which product features and datasets.
- Integration with major
- authentication backends (database, OpenID, LDAP, OAuth, REMOTE_USER, ...)
-* A lightweight semantic layer, allowing to control how data sources are
- exposed to the user by defining dimensions and metrics
-* Out of the box support for most SQL-speaking databases
-* Deep integration with Druid allows for Superset to stay blazing fast while
- slicing and dicing large, realtime datasets
-* Fast loading dashboards with configurable caching
+
+Viewed
+
+A modern, enterprise-ready business intelligence web application. Apache Superset (Incubating) is a modern,
Review comment:
I think there's a tab `\t` here, let's break the line instead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org