You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by ko...@apache.org on 2005/12/28 20:06:12 UTC
svn commit: r359600 -
/jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow/SerializationTestCase.java
Author: kohsuke
Date: Wed Dec 28 11:06:06 2005
New Revision: 359600
URL: http://svn.apache.org/viewcvs?rev=359600&view=rev
Log:
fixed this test case.
Modified:
jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow/SerializationTestCase.java
Modified: jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow/SerializationTestCase.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow/SerializationTestCase.java?rev=359600&r1=359599&r2=359600&view=diff
==============================================================================
--- jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow/SerializationTestCase.java (original)
+++ jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow/SerializationTestCase.java Wed Dec 28 11:06:06 2005
@@ -51,13 +51,13 @@
final Continuation c1 = (Continuation) o;
- final SimpleSerializableFlow r1 = (SimpleSerializableFlow) PrivateAccessor.getField(PrivateAccessor.getField(c1, "stack"), "runnable");
+ final SimpleSerializableFlow r1 = (SimpleSerializableFlow) PrivateAccessor.getField(PrivateAccessor.getField(c1, "stackRecorder"), "runnable");
assertTrue(r1.g == 0);
assertTrue(r1.l == 0);
final Continuation c2 = Continuation.continueWith(c1);
- final SimpleSerializableFlow r2 = (SimpleSerializableFlow) PrivateAccessor.getField(PrivateAccessor.getField(c1, "stack"), "runnable");
+ final SimpleSerializableFlow r2 = (SimpleSerializableFlow) PrivateAccessor.getField(PrivateAccessor.getField(c1, "stackRecorder"), "runnable");
assertTrue(r2.g == 1);
assertTrue(r2.l == 1);
@@ -78,7 +78,7 @@
final Runnable r3 = new SimpleSerializableFlow();
Continuation c3 = Continuation.startWith(new Invoker(r3));
assertTrue(c3 != null);
- assertTrue(c3.isSerializable());
+ assertTrue(!c3.isSerializable());
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: svn commit: r359600 - /jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow/SerializationTestCase.java
Posted by Kohsuke Kawaguchi <ko...@sun.com>.
Torsten Curdt wrote:
>>
>> @@ -78,7 +78,7 @@
>> final Runnable r3 = new SimpleSerializableFlow();
>> Continuation c3 = Continuation.startWith(new Invoker(r3));
>> assertTrue(c3 != null);
>> - assertTrue(c3.isSerializable());
>> + assertTrue(!c3.isSerializable());
>
> Thanks for fixing the other stuff ...but this *should*
> be serializable.
>
> assertTrue(c3.isSerializable());
>
> The Invoker is not getting instrumented and should not
> affect the suspend/resume nor serialization. That's what
> the test is about.
OK. Rolled back the test case change.
--
Kohsuke Kawaguchi
Sun Microsystems kohsuke.kawaguchi@sun.com
Re: svn commit: r359600 - /jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow/SerializationTestCase.java
Posted by Torsten Curdt <tc...@apache.org>.
>
> @@ -78,7 +78,7 @@
> final Runnable r3 = new SimpleSerializableFlow();
> Continuation c3 = Continuation.startWith(new Invoker(r3));
> assertTrue(c3 != null);
> - assertTrue(c3.isSerializable());
> + assertTrue(!c3.isSerializable());
Thanks for fixing the other stuff ...but this *should*
be serializable.
assertTrue(c3.isSerializable());
The Invoker is not getting instrumented and should not
affect the suspend/resume nor serialization. That's what
the test is about.
cheers
--
Torsten