You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ta...@apache.org on 2016/12/16 19:48:35 UTC
qpid-jms git commit: QPIDJMS-232 Clean up some now unused methods in
the connection class
Repository: qpid-jms
Updated Branches:
refs/heads/master 8d211bc8e -> 2382124f7
QPIDJMS-232 Clean up some now unused methods in the connection class
Now that we care connecting on create there are some set methods in
JmsConnection that are no longer needed and can be removed to prevent
any confusion.
Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/2382124f
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/2382124f
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/2382124f
Branch: refs/heads/master
Commit: 2382124f7a84d88d2c5bcc0714502b1253ca4f7f
Parents: 8d211bc
Author: Timothy Bish <ta...@gmail.com>
Authored: Fri Dec 16 14:48:25 2016 -0500
Committer: Timothy Bish <ta...@gmail.com>
Committed: Fri Dec 16 14:48:25 2016 -0500
----------------------------------------------------------------------
.../java/org/apache/qpid/jms/JmsConnection.java | 20 ++------------------
1 file changed, 2 insertions(+), 18 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/2382124f/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnection.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnection.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnection.java
index d04d75d..cb6ac50 100644
--- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnection.java
+++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnection.java
@@ -997,26 +997,14 @@ public class JmsConnection implements AutoCloseable, Connection, TopicConnection
return connectionInfo.getConfiguredURI();
}
- void setConfiguredURI(URI uri) {
- connectionInfo.setConfiguredURI(uri);
- }
-
public URI getConnectedURI() {
return connectionInfo.getConnectedURI();
}
- void setConnectedURI(URI connectedURI) {
- connectionInfo.setConnectedURI(connectedURI);
- }
-
public String getUsername() {
return connectionInfo.getUsername();
}
- void setUsername(String username) {
- connectionInfo.setUsername(username);;
- }
-
byte[] getEncodedUsername() {
return connectionInfo.getEncodedUsername();
}
@@ -1025,10 +1013,6 @@ public class JmsConnection implements AutoCloseable, Connection, TopicConnection
return connectionInfo.getPassword();
}
- void setPassword(String password) {
- this.connectionInfo.setPassword(password);
- }
-
public boolean isConnected() {
return connected.get();
}
@@ -1193,7 +1177,7 @@ public class JmsConnection implements AutoCloseable, Connection, TopicConnection
LOG.debug("Connection {} is finalizing recovery.", connectionInfo.getId());
setMessageFactory(provider.getMessageFactory());
- setConnectedURI(provider.getRemoteURI());
+ connectionInfo.setConnectedURI(provider.getRemoteURI());
for (JmsSession session : sessions.values()) {
session.onConnectionRecovered(provider);
@@ -1223,7 +1207,7 @@ public class JmsConnection implements AutoCloseable, Connection, TopicConnection
public void onConnectionEstablished(final URI remoteURI) {
LOG.info("Connection {} connected to remote Broker: {}", connectionInfo.getId(), remoteURI);
setMessageFactory(provider.getMessageFactory());
- setConnectedURI(provider.getRemoteURI());
+ connectionInfo.setConnectedURI(provider.getRemoteURI());
// Run the application callbacks on the connection executor to allow the provider to
// return to its normal processing without waiting for client level processing to finish.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org