You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/10/12 11:54:04 UTC
[GitHub] [ignite-3] ygerzhedovich opened a new pull request, #1195: IGNITE-17816:Sort out and merge Calcite tickets to Ignite 3.0 (step 7)
ygerzhedovich opened a new pull request, #1195:
URL: https://github.com/apache/ignite-3/pull/1195
IGNITE-16443 Fix nulls processing in search rows - Fixes #9792.
Signed-off-by: Aleksey Plekhanov <pl...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #1195: IGNITE-17816:Sort out and merge Calcite tickets to Ignite 3.0 (step 7)
Posted by GitBox <gi...@apache.org>.
ygerzhedovich commented on code in PR #1195:
URL: https://github.com/apache/ignite-3/pull/1195#discussion_r997033771
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java:
##########
@@ -92,6 +92,11 @@
public class SqlQueryProcessor implements QueryProcessor {
private static final IgniteLogger LOG = Loggers.forClass(SqlQueryProcessor.class);
+ /**
+ * Default planner timeout, in ms.
+ */
+ private static final long PLANNER_TIMEOUT = 15000L;
Review Comment:
yes, we have a separate ticket for that purpose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #1195: IGNITE-17816:Sort out and merge Calcite tickets to Ignite 3.0 (step 7)
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on code in PR #1195:
URL: https://github.com/apache/ignite-3/pull/1195#discussion_r997030623
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java:
##########
@@ -92,6 +92,11 @@
public class SqlQueryProcessor implements QueryProcessor {
private static final IgniteLogger LOG = Loggers.forClass(SqlQueryProcessor.class);
+ /**
+ * Default planner timeout, in ms.
+ */
+ private static final long PLANNER_TIMEOUT = 15000L;
Review Comment:
```suggestion
/** Default planner timeout, in ms. */
private static final long PLANNER_TIMEOUT = 15000L;
```
Do we plan to make it configurable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov merged pull request #1195: IGNITE-17816:Sort out and merge Calcite tickets to Ignite 3.0 (step 7)
Posted by GitBox <gi...@apache.org>.
AMashenkov merged PR #1195:
URL: https://github.com/apache/ignite-3/pull/1195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org