You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/26 14:37:07 UTC

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4215: Enable account settings to be visible under domain settings

DaanHoogland commented on a change in pull request #4215:
URL: https://github.com/apache/cloudstack/pull/4215#discussion_r602339698



##########
File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -6485,6 +6492,7 @@ public String getConfigComponentName() {
     @Override
     public ConfigKey<?>[] getConfigKeys() {
         return new ConfigKey<?>[] {SystemVMUseLocalStorage, IOPS_MAX_READ_LENGTH, IOPS_MAX_WRITE_LENGTH,
-                BYTES_MAX_READ_LENGTH, BYTES_MAX_WRITE_LENGTH, ADD_HOST_ON_SERVICE_RESTART_KVM, SET_HOST_DOWN_TO_MAINTENANCE};
+                BYTES_MAX_READ_LENGTH, BYTES_MAX_WRITE_LENGTH, ADD_HOST_ON_SERVICE_RESTART_KVM, SET_HOST_DOWN_TO_MAINTENANCE,
+                EnableAccountSettingsForDomain, EnableDomainSettingsForChildDomain};

Review comment:
       naming convention for static final dictates as above ALL_CAPS_WITH_UNDERSCORES

##########
File path: engine/schema/src/main/java/com/cloud/domain/dao/DomainDetailsDaoImpl.java
##########
@@ -98,7 +107,24 @@ public Scope getScope() {
 
     @Override
     public String getConfigValue(long id, ConfigKey<?> key) {
-        DomainDetailVO vo = findDetail(id, key.key());
+        DomainDetailVO vo = null;
+        String enableDomainSettingsForChildDomain = _configDao.getValue("enable.domain.settings.for.child.domain");

Review comment:
       this string should probably come from some static final as now it is encoded twice (at least)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org