You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by jo...@gmail.com on 2010/07/09 00:32:11 UTC

Re: Adding StyleTagProxyImportRewriter (issue1704047)

Only one comment -- I already took care of it and committed.


http://codereview.appspot.com/1704047/diff/22001/23001
File
main/java/org/apache/shindig/gadgets/rewrite/StyleTagExtractorVisitor.java
(right):

http://codereview.appspot.com/1704047/diff/22001/23001#newcode48
main/java/org/apache/shindig/gadgets/rewrite/StyleTagExtractorVisitor.java:48:
return super.visit(gadget, node);
I appreciate the insistence on not duplicating code, but in this case
we're trading 3 lines for extension of another class -- I'd just revert
this file.

http://codereview.appspot.com/1704047/show