You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/12 19:03:58 UTC

[GitHub] [pulsar-client-go] merlimat commented on a change in pull request #507: Expose NumPartitions() method on producer interface and GetHashingFunction() method

merlimat commented on a change in pull request #507:
URL: https://github.com/apache/pulsar-client-go/pull/507#discussion_r611882360



##########
File path: pulsar/producer.go
##########
@@ -199,3 +204,15 @@ type Producer interface {
 	// of errors, pending writes will not be retried.
 	Close()
 }
+
+// GetHashingFunction return the corresponding hashing function for the hashing scheme
+func GetHashingFunction(s HashingScheme) func(string) uint32 {

Review comment:
       Why do we need to expose this publicly? An application is free to use a custom message router function, at that point it can use any hashing function.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org