You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by Guillaume Nodet <gn...@apache.org> on 2019/07/01 12:09:51 UTC

Build startup speed

I've been spending quite some time last week to try to improve the time
spent by maven before actually starting building something.
I've opened a few PR on maven which should reduce by 50% the time, but I
noticed that a lot of time is spent because the camel parent pom has 800
dependencies in the dependency management section.
So I was wondering if we should remove the camel modules from the
dependency management section.  I experimented that, so this is available
at
  https://github.com/apache/camel/pull/3009
With the above , the execution of `mvn foo` (which fails fast) goes from 54
seconds to 39 seconds. With the addition maven PRs, it goes down to 28
seconds.
Thoughts ?

-- 
------------------------
Guillaume Nodet

Re: Build startup speed

Posted by Claus Ibsen <cl...@gmail.com>.
Hi

+1
I think this is good and would be great to get the speedup.

And yes camel-bom should be the BOM that end users will use and import
And camel-parent should be for the internal usage of the Camel project itself.




On Mon, Jul 1, 2019 at 3:40 PM Guillaume Nodet <gn...@apache.org> wrote:
>
> Ah, good point.  This was definitely not expected.
> It seems to be a side effect of the generation of the BOM by the
> bom-generator-maven-plugin which uses the dependency management section of
> the parent I suppose.  This would definitely need to be reworked if there's
> a consensus to go ahead in this direction.
>
> Le lun. 1 juil. 2019 à 15:34, Willem Jiang <wi...@gmail.com> a
> écrit :
>
> > Hi Guillaume,
> >
> > I checked the PR[1], the dependencies of camel components in the
> > bom/camel-bom/pom.xml were removed.
> > Please double check it if I missed anything.
> >
> > [1]https://github.com/apache/camel/pull/3009
> >
> > Willem Jiang
> >
> > Twitter: willemjiang
> > Weibo: 姜宁willem
> >
> > On Mon, Jul 1, 2019 at 8:31 PM Guillaume Nodet <gn...@apache.org> wrote:
> > >
> > > 'm not talking about modifying the camel-bom, but the camel-parent.  So
> > > this should mostly affect project that inherit from camel-parent, and I
> > > don't think that's the correct way of using camel, users should import
> > the
> > > bom instead, since CAMEL-8502.
> > >
> > > Le lun. 1 juil. 2019 à 14:25, Willem Jiang <wi...@gmail.com> a
> > > écrit :
> > >
> > > > When user use the bom file, they don't need to specify the version of
> > > > camel-xxx component.
> > > > If we remove the dependency management section form  BOM, the old
> > > > pom.xml may not work any more.
> > > > They need to specify the camel version for the camel-xxx component in
> > > > their pom.
> > > >
> > > > We need to inform the end user in the migration document, if we merged
> > the
> > > > PR.
> > > >
> > > > Willem Jiang
> > > >
> > > > Twitter: willemjiang
> > > > Weibo: 姜宁willem
> > > >
> > > > On Mon, Jul 1, 2019 at 8:10 PM Guillaume Nodet <gn...@apache.org>
> > wrote:
> > > > >
> > > > > I've been spending quite some time last week to try to improve the
> > time
> > > > > spent by maven before actually starting building something.
> > > > > I've opened a few PR on maven which should reduce by 50% the time,
> > but I
> > > > > noticed that a lot of time is spent because the camel parent pom has
> > 800
> > > > > dependencies in the dependency management section.
> > > > > So I was wondering if we should remove the camel modules from the
> > > > > dependency management section.  I experimented that, so this is
> > available
> > > > > at
> > > > >   https://github.com/apache/camel/pull/3009
> > > > > With the above , the execution of `mvn foo` (which fails fast) goes
> > from
> > > > 54
> > > > > seconds to 39 seconds. With the addition maven PRs, it goes down to
> > 28
> > > > > seconds.
> > > > > Thoughts ?
> > > > >
> > > > > --
> > > > > ------------------------
> > > > > Guillaume Nodet
> > > >
> > >
> > >
> > > --
> > > ------------------------
> > > Guillaume Nodet
> >
>
>
> --
> ------------------------
> Guillaume Nodet



-- 
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2

Re: Build startup speed

Posted by Guillaume Nodet <gn...@apache.org>.
Ah, good point.  This was definitely not expected.
It seems to be a side effect of the generation of the BOM by the
bom-generator-maven-plugin which uses the dependency management section of
the parent I suppose.  This would definitely need to be reworked if there's
a consensus to go ahead in this direction.

Le lun. 1 juil. 2019 à 15:34, Willem Jiang <wi...@gmail.com> a
écrit :

> Hi Guillaume,
>
> I checked the PR[1], the dependencies of camel components in the
> bom/camel-bom/pom.xml were removed.
> Please double check it if I missed anything.
>
> [1]https://github.com/apache/camel/pull/3009
>
> Willem Jiang
>
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Mon, Jul 1, 2019 at 8:31 PM Guillaume Nodet <gn...@apache.org> wrote:
> >
> > 'm not talking about modifying the camel-bom, but the camel-parent.  So
> > this should mostly affect project that inherit from camel-parent, and I
> > don't think that's the correct way of using camel, users should import
> the
> > bom instead, since CAMEL-8502.
> >
> > Le lun. 1 juil. 2019 à 14:25, Willem Jiang <wi...@gmail.com> a
> > écrit :
> >
> > > When user use the bom file, they don't need to specify the version of
> > > camel-xxx component.
> > > If we remove the dependency management section form  BOM, the old
> > > pom.xml may not work any more.
> > > They need to specify the camel version for the camel-xxx component in
> > > their pom.
> > >
> > > We need to inform the end user in the migration document, if we merged
> the
> > > PR.
> > >
> > > Willem Jiang
> > >
> > > Twitter: willemjiang
> > > Weibo: 姜宁willem
> > >
> > > On Mon, Jul 1, 2019 at 8:10 PM Guillaume Nodet <gn...@apache.org>
> wrote:
> > > >
> > > > I've been spending quite some time last week to try to improve the
> time
> > > > spent by maven before actually starting building something.
> > > > I've opened a few PR on maven which should reduce by 50% the time,
> but I
> > > > noticed that a lot of time is spent because the camel parent pom has
> 800
> > > > dependencies in the dependency management section.
> > > > So I was wondering if we should remove the camel modules from the
> > > > dependency management section.  I experimented that, so this is
> available
> > > > at
> > > >   https://github.com/apache/camel/pull/3009
> > > > With the above , the execution of `mvn foo` (which fails fast) goes
> from
> > > 54
> > > > seconds to 39 seconds. With the addition maven PRs, it goes down to
> 28
> > > > seconds.
> > > > Thoughts ?
> > > >
> > > > --
> > > > ------------------------
> > > > Guillaume Nodet
> > >
> >
> >
> > --
> > ------------------------
> > Guillaume Nodet
>


-- 
------------------------
Guillaume Nodet

Re: Build startup speed

Posted by Willem Jiang <wi...@gmail.com>.
Hi Guillaume,

I checked the PR[1], the dependencies of camel components in the
bom/camel-bom/pom.xml were removed.
Please double check it if I missed anything.

[1]https://github.com/apache/camel/pull/3009

Willem Jiang

Twitter: willemjiang
Weibo: 姜宁willem

On Mon, Jul 1, 2019 at 8:31 PM Guillaume Nodet <gn...@apache.org> wrote:
>
> 'm not talking about modifying the camel-bom, but the camel-parent.  So
> this should mostly affect project that inherit from camel-parent, and I
> don't think that's the correct way of using camel, users should import the
> bom instead, since CAMEL-8502.
>
> Le lun. 1 juil. 2019 à 14:25, Willem Jiang <wi...@gmail.com> a
> écrit :
>
> > When user use the bom file, they don't need to specify the version of
> > camel-xxx component.
> > If we remove the dependency management section form  BOM, the old
> > pom.xml may not work any more.
> > They need to specify the camel version for the camel-xxx component in
> > their pom.
> >
> > We need to inform the end user in the migration document, if we merged the
> > PR.
> >
> > Willem Jiang
> >
> > Twitter: willemjiang
> > Weibo: 姜宁willem
> >
> > On Mon, Jul 1, 2019 at 8:10 PM Guillaume Nodet <gn...@apache.org> wrote:
> > >
> > > I've been spending quite some time last week to try to improve the time
> > > spent by maven before actually starting building something.
> > > I've opened a few PR on maven which should reduce by 50% the time, but I
> > > noticed that a lot of time is spent because the camel parent pom has 800
> > > dependencies in the dependency management section.
> > > So I was wondering if we should remove the camel modules from the
> > > dependency management section.  I experimented that, so this is available
> > > at
> > >   https://github.com/apache/camel/pull/3009
> > > With the above , the execution of `mvn foo` (which fails fast) goes from
> > 54
> > > seconds to 39 seconds. With the addition maven PRs, it goes down to 28
> > > seconds.
> > > Thoughts ?
> > >
> > > --
> > > ------------------------
> > > Guillaume Nodet
> >
>
>
> --
> ------------------------
> Guillaume Nodet

Re: Build startup speed

Posted by Guillaume Nodet <gn...@apache.org>.
'm not talking about modifying the camel-bom, but the camel-parent.  So
this should mostly affect project that inherit from camel-parent, and I
don't think that's the correct way of using camel, users should import the
bom instead, since CAMEL-8502.

Le lun. 1 juil. 2019 à 14:25, Willem Jiang <wi...@gmail.com> a
écrit :

> When user use the bom file, they don't need to specify the version of
> camel-xxx component.
> If we remove the dependency management section form  BOM, the old
> pom.xml may not work any more.
> They need to specify the camel version for the camel-xxx component in
> their pom.
>
> We need to inform the end user in the migration document, if we merged the
> PR.
>
> Willem Jiang
>
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Mon, Jul 1, 2019 at 8:10 PM Guillaume Nodet <gn...@apache.org> wrote:
> >
> > I've been spending quite some time last week to try to improve the time
> > spent by maven before actually starting building something.
> > I've opened a few PR on maven which should reduce by 50% the time, but I
> > noticed that a lot of time is spent because the camel parent pom has 800
> > dependencies in the dependency management section.
> > So I was wondering if we should remove the camel modules from the
> > dependency management section.  I experimented that, so this is available
> > at
> >   https://github.com/apache/camel/pull/3009
> > With the above , the execution of `mvn foo` (which fails fast) goes from
> 54
> > seconds to 39 seconds. With the addition maven PRs, it goes down to 28
> > seconds.
> > Thoughts ?
> >
> > --
> > ------------------------
> > Guillaume Nodet
>


-- 
------------------------
Guillaume Nodet

Re: Build startup speed

Posted by Willem Jiang <wi...@gmail.com>.
When user use the bom file, they don't need to specify the version of
camel-xxx component.
If we remove the dependency management section form  BOM, the old
pom.xml may not work any more.
They need to specify the camel version for the camel-xxx component in their pom.

We need to inform the end user in the migration document, if we merged the PR.

Willem Jiang

Twitter: willemjiang
Weibo: 姜宁willem

On Mon, Jul 1, 2019 at 8:10 PM Guillaume Nodet <gn...@apache.org> wrote:
>
> I've been spending quite some time last week to try to improve the time
> spent by maven before actually starting building something.
> I've opened a few PR on maven which should reduce by 50% the time, but I
> noticed that a lot of time is spent because the camel parent pom has 800
> dependencies in the dependency management section.
> So I was wondering if we should remove the camel modules from the
> dependency management section.  I experimented that, so this is available
> at
>   https://github.com/apache/camel/pull/3009
> With the above , the execution of `mvn foo` (which fails fast) goes from 54
> seconds to 39 seconds. With the addition maven PRs, it goes down to 28
> seconds.
> Thoughts ?
>
> --
> ------------------------
> Guillaume Nodet

Re: Build startup speed

Posted by Andrea Cosentino <an...@gmail.com>.
In my opinion, this makes completely sense.

Il giorno lun 1 lug 2019 alle ore 14:10 Guillaume Nodet <gn...@apache.org>
ha scritto:

> I've been spending quite some time last week to try to improve the time
> spent by maven before actually starting building something.
> I've opened a few PR on maven which should reduce by 50% the time, but I
> noticed that a lot of time is spent because the camel parent pom has 800
> dependencies in the dependency management section.
> So I was wondering if we should remove the camel modules from the
> dependency management section.  I experimented that, so this is available
> at
>   https://github.com/apache/camel/pull/3009
> With the above , the execution of `mvn foo` (which fails fast) goes from 54
> seconds to 39 seconds. With the addition maven PRs, it goes down to 28
> seconds.
> Thoughts ?
>
> --
> ------------------------
> Guillaume Nodet
>