You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by "beiwei30 (GitHub)" <gi...@apache.org> on 2019/01/16 07:43:15 UTC

[GitHub] [incubator-dubbo] beiwei30 commented on pull request #3093: [Dubbo-3069]Use regular expressions to judge fix #3069

I am not persuaded that 'StringUtils.isNumeric()' is required here. In my opinion, JDK has already offered the nice API and we should stick to it. What we need to do is to catch **NumberFormatException** and return 'null' if necessary.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3093 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org