You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Vladimir Prus <gh...@cs.msu.su> on 2003/03/21 15:28:19 UTC
Dump/load changes data?
Hello,
I just noticed something strange. I've done a dump/reload cycle and the
resulting repository is different! I get:
bash-2.05a$ svn pl file:///home/ghost/local/svn_loaded/trunk/ocean/whale
Properties on 'file:///home/ghost/local/svn_loaded/trunk/ocean/whale':
svn:externals
bash-2.05a$ svn pl file:///home/ghost/local/svn/trunk/ocean/whale
bash-2.05a$
Where "svn" is the repository I've dumped, and "svn_loaded" is the repository
loaded from the dump file. Is there any possible error on my part, or this is
a bug?
I'm sure that Apache was not running when I was doing dump and no process
was accessing repository. Svn is at revision 5418.
If dump file is needed, it's at http://zigzag.cs.msu.su:7813/svn_dump.gz
The property was removed in the last revision, and I believe it's correctly
recorded in the dump file, but I'm not sure.
- Volodya
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Dump/load changes data?
Posted by Vladimir Prus <gh...@cs.msu.su>.
Ben,
> > Ah! I see the bug. Cmpilato pointed it out -- it's a bug in the
> > dumpfile parser. I'll fix it now and commit soon.
>
> OK, Volodya, I've committed the fix in r5420. This was a really
> serious bug... apparently our 'svnadmin load' parser has *never*
> honored property deletions! Thank you for pointing this out.
Thanks for fixing it!
> I reloaded your dumpfile, and the property deletion works now.
> /trunk/ocean/whale in r165 has no properties at all.
Confirmed. I now reloaded all my repositories.
- Volodya
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Dump/load changes data?
Posted by Ben Collins-Sussman <su...@collab.net>.
Ben Collins-Sussman <su...@collab.net> writes:
> Vladimir Prus <gh...@cs.msu.su> writes:
>
> > I just noticed something strange. I've done a dump/reload cycle and the
> > resulting repository is different! I get:
> >
> > bash-2.05a$ svn pl file:///home/ghost/local/svn_loaded/trunk/ocean/whale
> > Properties on 'file:///home/ghost/local/svn_loaded/trunk/ocean/whale':
> > svn:externals
> > bash-2.05a$ svn pl file:///home/ghost/local/svn/trunk/ocean/whale
> > bash-2.05a$
>
> Ah! I see the bug. Cmpilato pointed it out -- it's a bug in the
> dumpfile parser. I'll fix it now and commit soon.
OK, Volodya, I've committed the fix in r5420. This was a really
serious bug... apparently our 'svnadmin load' parser has *never*
honored property deletions! Thank you for pointing this out.
I reloaded your dumpfile, and the property deletion works now.
/trunk/ocean/whale in r165 has no properties at all.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Dump/load changes data?
Posted by Ben Collins-Sussman <su...@collab.net>.
Vladimir Prus <gh...@cs.msu.su> writes:
> I just noticed something strange. I've done a dump/reload cycle and the
> resulting repository is different! I get:
>
> bash-2.05a$ svn pl file:///home/ghost/local/svn_loaded/trunk/ocean/whale
> Properties on 'file:///home/ghost/local/svn_loaded/trunk/ocean/whale':
> svn:externals
> bash-2.05a$ svn pl file:///home/ghost/local/svn/trunk/ocean/whale
> bash-2.05a$
Ah! I see the bug. Cmpilato pointed it out -- it's a bug in the
dumpfile parser. I'll fix it now and commit soon.
Michael Price, this should probably go into 0.20.1.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Dump/load changes data?
Posted by Ben Collins-Sussman <su...@collab.net>.
Ben Collins-Sussman <su...@collab.net> writes:
> Looking at the last revision in the dumpfile, I see:
>
> Node-path: /trunk/ocean/whale
> Node-kind: dir
> Node-action: change
> Prop-content-length: 10
> Content-length: 10
>
> PROPS-END
>
>
>
> This looks odd to me. Is this how our dumpfile format signifies a
> property deletion?
Ah! I'm noticing something new: this node (in the original dumpfile
from Volodya) has a '/' at the front. Every node in his
dumpfile is a relative path: "trunk/...", except for exactly three (!):
In r78:
Node-path: /trunk/whale
Node-kind: dir
Node-action: change
Prop-content-length: 168
Content-length: 168
K 13
svn:externals
V 132
lib/config_db http://zigzag.cs.msu.su:7813/repos/config_db/trunk
lib/lr_library http://zigzag.cs.msu.su:7813/repos/trunk/lr_library
PROPS-END
In r165:
Node-path: /trunk/ocean
Node-kind: dir
Node-action: change
Prop-content-length: 160
Content-length: 160
K 13
svn:externals
V 124
program_options http://zigzag.cs.msu.su:7813/repos/trunk/program_options
nstl http://zigzag.cs.msu.su:7813/repos/trunk/nstl
PROPS-END
Node-path: /trunk/ocean/whale
Node-kind: dir
Node-action: change
Prop-content-length: 10
Content-length: 10
PROPS-END
> Even stranger: I then did a new dump of the repository, and looked at
> r165. There's no /trunk/ocean/whale node in the entire repository!
And in the newdump, only the first two 'absolute path' nodes exist,
not the third one.
I think these clues are important somehow.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Dump/load changes data?
Posted by Ben Collins-Sussman <su...@collab.net>.
Vladimir Prus <gh...@cs.msu.su> writes:
> bash-2.05a$ svn pl file:///home/ghost/local/svn_loaded/trunk/ocean/whale
> Properties on 'file:///home/ghost/local/svn_loaded/trunk/ocean/whale':
> svn:externals
> bash-2.05a$ svn pl file:///home/ghost/local/svn/trunk/ocean/whale
> bash-2.05a$
>
> If dump file is needed, it's at http://zigzag.cs.msu.su:7813/svn_dump.gz
> The property was removed in the last revision, and I believe it's correctly
> recorded in the dump file, but I'm not sure.
Hmmmm, very interesting!
I was able to load your dumpfile and indeed, in the HEAD revision
(r165), /trunk/ocean/whale has the svn:externals property.
Looking at the last revision in the dumpfile, I see:
Node-path: /trunk/ocean/whale
Node-kind: dir
Node-action: change
Prop-content-length: 10
Content-length: 10
PROPS-END
This looks odd to me. Is this how our dumpfile format signifies a
property deletion?
Even stranger: I then did a new dump of the repository, and looked at
r165. There's no /trunk/ocean/whale node in the entire repository!
Something is very wrong here.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org