You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/03/01 14:28:58 UTC

[GitHub] pnowojski commented on issue #7604: [FLINK-11249] FlinkKafkaProducer011 can not be migrated to FlinkKafkaProducer

pnowojski commented on issue #7604: [FLINK-11249] FlinkKafkaProducer011 can not be migrated to FlinkKafkaProducer
URL: https://github.com/apache/flink/pull/7604#issuecomment-468682545
 
 
   There were couple of issues with the tests that you proposed @tvielgouarin. One of them was that you were catching and ignoring the exception in your tests and this was hiding some issues, while tests were "passing" and there was quite a lot of code duplication. I have reimplemented most of it and opened another PR  (it has some refactoring/clean ups):
   https://github.com/apache/flink/pull/7677
   
   The equivalent code to your PR is [this commit](
   https://github.com/apache/flink/pull/7677/commits/673e93a4104fd7bcb9f54275008cb2f90d81c692) from my PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services