You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Attila Király (JIRA)" <ji...@apache.org> on 2011/04/29 10:08:03 UTC
[jira] [Created] (WICKET-3655) Component should use the new
renderHead(Component, IHeaderResponse) instead of the old
renderHead(IHeaderResponse)
Component should use the new renderHead(Component, IHeaderResponse) instead of the old renderHead(IHeaderResponse)
------------------------------------------------------------------------------------------------------------------
Key: WICKET-3655
URL: https://issues.apache.org/jira/browse/WICKET-3655
Project: Wicket
Issue Type: Bug
Components: wicket-core
Reporter: Attila Király
Priority: Trivial
Attachments: WICKET-3655.patch
This is not causing any errors but for consistency the framework should probably call the IHeaderContributor method instead of the delegated custom method.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3655) Component should use the new
renderHead(Component, IHeaderResponse) instead of the old
renderHead(IHeaderResponse)
Posted by "Attila Király (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Attila Király updated WICKET-3655:
----------------------------------
Affects Version/s: 1.5-RC3
> Component should use the new renderHead(Component, IHeaderResponse) instead of the old renderHead(IHeaderResponse)
> ------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3655
> URL: https://issues.apache.org/jira/browse/WICKET-3655
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-RC3
> Reporter: Attila Király
> Priority: Trivial
> Attachments: WICKET-3655.patch
>
>
> This is not causing any errors but for consistency the framework should probably call the IHeaderContributor method instead of the delegated custom method.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-3655) Component should use the new
renderHead(Component, IHeaderResponse) instead of the old
renderHead(IHeaderResponse)
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-3655.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.5-RC5
Assignee: Igor Vaynberg
> Component should use the new renderHead(Component, IHeaderResponse) instead of the old renderHead(IHeaderResponse)
> ------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3655
> URL: https://issues.apache.org/jira/browse/WICKET-3655
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-RC3
> Reporter: Attila Király
> Assignee: Igor Vaynberg
> Priority: Trivial
> Fix For: 1.5-RC5
>
> Attachments: WICKET-3655.patch
>
>
> This is not causing any errors but for consistency the framework should probably call the IHeaderContributor method instead of the delegated custom method.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3655) Component should use the new
renderHead(Component, IHeaderResponse) instead of the old
renderHead(IHeaderResponse)
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028349#comment-13028349 ]
Martin Grigorov commented on WICKET-3655:
-----------------------------------------
I agree that the current state is weird, but passing 'this' to #renderHead(Component, IHeaderResponse) also makes me feel nervous.
But at the end I think passing 'this' is better.
Other devs: opinion?
> Component should use the new renderHead(Component, IHeaderResponse) instead of the old renderHead(IHeaderResponse)
> ------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3655
> URL: https://issues.apache.org/jira/browse/WICKET-3655
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-RC3
> Reporter: Attila Király
> Priority: Trivial
> Attachments: WICKET-3655.patch
>
>
> This is not causing any errors but for consistency the framework should probably call the IHeaderContributor method instead of the delegated custom method.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3655) Component should use the new
renderHead(Component, IHeaderResponse) instead of the old
renderHead(IHeaderResponse)
Posted by "Attila Király (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Attila Király updated WICKET-3655:
----------------------------------
Attachment: WICKET-3655.patch
Attaching patch. Also contains a javadoc fix as the old method is now not inheriting the javadoc.
> Component should use the new renderHead(Component, IHeaderResponse) instead of the old renderHead(IHeaderResponse)
> ------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3655
> URL: https://issues.apache.org/jira/browse/WICKET-3655
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Reporter: Attila Király
> Priority: Trivial
> Attachments: WICKET-3655.patch
>
>
> This is not causing any errors but for consistency the framework should probably call the IHeaderContributor method instead of the delegated custom method.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3655) Component should use the new
renderHead(Component, IHeaderResponse) instead of the old
renderHead(IHeaderResponse)
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028735#comment-13028735 ]
Pedro Santos commented on WICKET-3655:
--------------------------------------
The consistency can be improved by assembling the component and IHeaderResponse in an agrregation type like IResource.Attributes do to assemble the request and response.
Pass an object instance to itself as method parameter looks weird.
> Component should use the new renderHead(Component, IHeaderResponse) instead of the old renderHead(IHeaderResponse)
> ------------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3655
> URL: https://issues.apache.org/jira/browse/WICKET-3655
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-RC3
> Reporter: Attila Király
> Priority: Trivial
> Attachments: WICKET-3655.patch
>
>
> This is not causing any errors but for consistency the framework should probably call the IHeaderContributor method instead of the delegated custom method.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira