You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2024/02/05 13:13:19 UTC
[PR] [CODEC-263] test for user reported issue [commons-codec]
elharo opened a new pull request, #240:
URL: https://github.com/apache/commons-codec/pull/240
Near as I can tell this issue doesn't reproduce and can be closed. @garydgregory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CODEC-263] test for user reported issue [commons-codec]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #240:
URL: https://github.com/apache/commons-codec/pull/240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CODEC-263] test for user reported issue [commons-codec]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #240:
URL: https://github.com/apache/commons-codec/pull/240#issuecomment-1926985996
## [Codecov](https://app.codecov.io/gh/apache/commons-codec/pull/240?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`71fb705`)](https://app.codecov.io/gh/apache/commons-codec/commit/71fb705e2d8737a08fe4d50400ff629a4097bf11?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 92.05% compared to head [(`81bfdb4`)](https://app.codecov.io/gh/apache/commons-codec/pull/240?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 92.04%.
> Report is 8 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #240 +/- ##
============================================
- Coverage 92.05% 92.04% -0.02%
Complexity 1746 1746
============================================
Files 67 67
Lines 4609 4602 -7
Branches 712 712
============================================
- Hits 4243 4236 -7
Misses 253 253
Partials 113 113
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/commons-codec/pull/240?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CODEC-263] test for user reported issue [commons-codec]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #240:
URL: https://github.com/apache/commons-codec/pull/240#discussion_r1478262382
##########
src/test/java/org/apache/commons/codec/binary/Base64Test.java:
##########
@@ -1309,6 +1309,11 @@ public void testUrlSafe() {
}
+ public void testCodec263(){
+ Base64.decodeBase64("publishMessage");
Review Comment:
I would make it more obvious IMO to refactor the magic strings into a local variable (or a constant).
##########
src/test/java/org/apache/commons/codec/binary/Base64Test.java:
##########
@@ -1309,6 +1309,11 @@ public void testUrlSafe() {
}
+ public void testCodec263(){
+ Base64.decodeBase64("publishMessage");
Review Comment:
@elharo
It would make it more obvious IMO to refactor the magic strings into a local variable (or a constant).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org