You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Leif Hedstrom (JIRA)" <ji...@apache.org> on 2015/05/27 01:45:18 UTC
[jira] [Commented] (TS-3638) Build errors on OS X / clang in
I_Lock.h asserts.
[ https://issues.apache.org/jira/browse/TS-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560139#comment-14560139 ]
Leif Hedstrom commented on TS-3638:
-----------------------------------
There are also some errors on SSLUtils.h, which are some C++ wonkiness (I ran into the same problem in a plugin of mine):
{code}
SSLUtils.cc:534:71: error: invalid use of non-static data member 'key_name'
memcpy(keyblock->keys[i].key_name, data, sizeof(ssl_ticket_key_t::key_name));
~~~~~~~~~~~~~~~~~~^~~~~~~~
SSLUtils.cc:535:75: error: invalid use of non-static data member 'key_name'
memcpy(keyblock->keys[i].hmac_secret, data + sizeof(ssl_ticket_key_t::key_name), sizeof(ssl_ticket_key_t::hmac_secret));
~~~~~~~~~~~~~~~~~~^~~~~~~~
SSLUtils.cc:535:111: error: invalid use of non-static data member 'hmac_secret'
memcpy(keyblock->keys[i].hmac_secret, data + sizeof(ssl_ticket_key_t::key_name), sizeof(ssl_ticket_key_t::hmac_secret));
~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
SSLUtils.cc:536:71: error: invalid use of non-static data member 'key_name'
memcpy(keyblock->keys[i].aes_key, data + sizeof(ssl_ticket_key_t::key_name) + sizeof(st_key_t::hmac_secret),
~~~~~~~~~~~~~~~~~~^~~~~~~~
SSLUtils.cc:536:108: error: invalid use of non-static data member 'hmac_secret'
memcpy(keyblock->keys[i].aes_key, data + sizeof(ssl_ticket_key_t::key_name) + sizeof(ssl_ticket_key_t::hmac_secret),
~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
SSLUtils.cc:537:37: error: invalid use of non-static data member 'aes_key'
sizeof(ssl_ticket_key_t::aes_key));
~~~~~~~~~~~~~~~~~~^~~~~~~
SSLUtils.cc:1904:72: error: invalid use of non-static data member 'key_name'
memcpy(keyname, most_recent_key.key_name, sizeof(ssl_ticket_key_t::key_name));
~~~~~~~~~~~~~~~~~~^~~~~~~~
SSLUtils.cc:1907:78: error: invalid use of non-static data member 'hmac_secret'
HMAC_Init_ex(hctx, most_recent_key.hmac_secret, sizeof(ssl_ticket_key_t::hmac_secret), EVP_sha256(), __null);
~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
SSLUtils.cc:1914:80: error: invalid use of non-static data member 'key_name'
if (memcmp(keyname, keyblock->keys[i].key_name, sizeof(ssl_ticket_key_t::key_name)) == 0) {
~~~~~~~~~~~~~~~~~~^~~~~~~~
SSLUtils.cc:1916:84: error: invalid use of non-static data member 'hmac_secret'
HMAC_Init_ex(hctx, keyblock->keys[i].hmac_secret, sizeof(ssl_ticket_key_t::hmac_secret), EVP_sha256(), __null);
{code}
> Build errors on OS X / clang in I_Lock.h asserts.
> -------------------------------------------------
>
> Key: TS-3638
> URL: https://issues.apache.org/jira/browse/TS-3638
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 6.0.0
>
>
> Seems some compilers complain on the volatility of thread_holding not being loaded in an ink_assert.
> {code}
> In file included from ./I_Continuation.h:40:
> ./I_Lock.h:350:15: error: expression result unused; assign into a variable to force a volatile load [-Werror,-Wunused-volatile-lvalue]
> (void)(m->thread_holding);
> ~ ^~~~~~~~~~~~~~
> ./I_Lock.h:383:15: error: expression result unused; assign into a variable to force a volatile load [-Werror,-Wunused-volatile-lvalue]
> (void)(m->thread_holding);
> ~ ^~~~~~~~~~~~~~
> ./I_Lock.h:421:17: error: expression result unused; assign into a variable to force a volatile load [-Werror,-Wunused-volatile-lvalue]
> (void)(m->thread_holding);
> ~ ^~~~~~~~~~~~~~
> 3 errors generated.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)