You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by nickwallen <gi...@git.apache.org> on 2016/06/06 20:50:22 UTC
[GitHub] incubator-metron pull request #144: METRON-211 Enable creation of new Kafka ...
GitHub user nickwallen opened a pull request:
https://github.com/apache/incubator-metron/pull/144
METRON-211 Enable creation of new Kafka topics during deployment
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/incubator-metron METRON-211
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/144.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #144
----
commit fc64bbba6ba884b99dd6ada60fbc3d8946ad20c1
Author: Nick Allen <ni...@nickallen.org>
Date: 2016-06-06T20:18:16Z
METRON-211 Enable creation of new Kafka topics during deployment
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #144: METRON-211 Enable creation of new Kafka ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-metron/pull/144
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #144: METRON-211 Enable creation of new Kafka ...
Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/144#discussion_r66057999
--- Diff: metron-deployment/roles/metron_streaming/tasks/main.yml ---
@@ -15,25 +15,18 @@
# limitations under the License.
#
---
-- name: Create Metron streaming directories
- file: path="{{ metron_directory }}/{{ item.name }}" state=directory mode=0755
+- name: Create Metron directories
+ file: path={{ metron_directory }}/{{ item }} state=directory mode=0755
with_items:
- - { name: 'lib'}
- - { name: 'bin'}
- - { name: 'config'}
+ - lib
+ - bin
+ - config
- name: Create Source Config Directory
- file:
- path: "{{ zookeeper_config_path }}"
- state: directory
- mode: 0755
+ file: path={{ zookeeper_config_path }} state=directory mode=0755
--- End diff --
Not a strong objection, but I do find the vertical presentation easier to read. I think it's because the yaml file decorator does a better job calling out the parameters in the vertical orientation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #144: METRON-211 Enable creation of new Kafka ...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/144#discussion_r66055523
--- Diff: metron-deployment/roles/metron_streaming/tasks/main.yml ---
@@ -15,25 +15,18 @@
# limitations under the License.
#
---
-- name: Create Metron streaming directories
- file: path="{{ metron_directory }}/{{ item.name }}" state=directory mode=0755
+- name: Create Metron directories
+ file: path={{ metron_directory }}/{{ item }} state=directory mode=0755
with_items:
- - { name: 'lib'}
- - { name: 'bin'}
- - { name: 'config'}
+ - lib
+ - bin
+ - config
- name: Create Source Config Directory
- file:
- path: "{{ zookeeper_config_path }}"
- state: directory
- mode: 0755
+ file: path={{ zookeeper_config_path }} state=directory mode=0755
--- End diff --
More compact. To my eyes it reads better with the other single-line code lines around it. Purely aesthetic. Can undo if there is an objection.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #144: METRON-211 Enable creation of new Kafka ...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/144#discussion_r66083599
--- Diff: metron-deployment/roles/metron_streaming/tasks/main.yml ---
@@ -15,25 +15,18 @@
# limitations under the License.
#
---
-- name: Create Metron streaming directories
- file: path="{{ metron_directory }}/{{ item.name }}" state=directory mode=0755
+- name: Create Metron directories
+ file: path={{ metron_directory }}/{{ item }} state=directory mode=0755
with_items:
- - { name: 'lib'}
- - { name: 'bin'}
- - { name: 'config'}
+ - lib
+ - bin
+ - config
- name: Create Source Config Directory
- file:
- path: "{{ zookeeper_config_path }}"
- state: directory
- mode: 0755
+ file: path={{ zookeeper_config_path }} state=directory mode=0755
--- End diff --
Reverted to original vertical presentation. Not a good enough reason for me to change it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #144: METRON-211 Enable creation of new Kafka topics ...
Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on the issue:
https://github.com/apache/incubator-metron/pull/144
\U0001f44d on this. Looks great to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #144: METRON-211 Enable creation of new Kafka topics ...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/144
+1 this looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #144: METRON-211 Enable creation of new Kafka ...
Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/144#discussion_r65988591
--- Diff: metron-deployment/roles/metron_streaming/tasks/main.yml ---
@@ -15,25 +15,18 @@
# limitations under the License.
#
---
-- name: Create Metron streaming directories
- file: path="{{ metron_directory }}/{{ item.name }}" state=directory mode=0755
+- name: Create Metron directories
+ file: path={{ metron_directory }}/{{ item }} state=directory mode=0755
with_items:
- - { name: 'lib'}
- - { name: 'bin'}
- - { name: 'config'}
+ - lib
+ - bin
+ - config
- name: Create Source Config Directory
- file:
- path: "{{ zookeeper_config_path }}"
- state: directory
- mode: 0755
+ file: path={{ zookeeper_config_path }} state=directory mode=0755
--- End diff --
I've noticed you're reverting tasks back to old-style parameter naming. Any reason for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---