You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/12/20 22:01:54 UTC
[GitHub] [kafka] akhileshchg opened a new pull request, #13029: MINOR: Add zk migration field to the ApiVersionsResponse
akhileshchg opened a new pull request, #13029:
URL: https://github.com/apache/kafka/pull/13029
This field will be used by the KRaft controller to see if the quorum is ready to handle zk -> kraft migration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe merged pull request #13029: MINOR: Add zk migration field to the ApiVersionsResponse
Posted by GitBox <gi...@apache.org>.
cmccabe merged PR #13029:
URL: https://github.com/apache/kafka/pull/13029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on a diff in pull request #13029: MINOR: Add zk migration field to the ApiVersionsResponse
Posted by GitBox <gi...@apache.org>.
cmccabe commented on code in PR #13029:
URL: https://github.com/apache/kafka/pull/13029#discussion_r1054647289
##########
clients/src/main/resources/common/message/ApiVersionsResponse.json:
##########
@@ -25,9 +25,12 @@
// not in the header. The length of the header must not change in order to guarantee the
// backward compatibility.
//
+ // Version 4 adds zk to kraft migration field to the response used to determine if the controller
+ // is ready for migration.
+ //
// Starting from Apache Kafka 2.4 (KIP-511), ApiKeys field is populated with the supported
// versions of the ApiVersionsRequest when an UNSUPPORTED_VERSION error is returned.
- "validVersions": "0-3",
+ "validVersions": "0-4",
Review Comment:
It's not necessary to increment the version when adding a tagged field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on a diff in pull request #13029: MINOR: Add zk migration field to the ApiVersionsResponse
Posted by GitBox <gi...@apache.org>.
cmccabe commented on code in PR #13029:
URL: https://github.com/apache/kafka/pull/13029#discussion_r1054764792
##########
clients/src/main/resources/common/message/ApiVersionsResponse.json:
##########
@@ -69,6 +69,9 @@
{"name": "MinVersionLevel", "type": "int16", "versions": "3+",
"about": "The cluster-wide finalized min version level for the feature."}
]
- }
+ },
+ { "name": "ZkMigrationReady", "type": "bool", "versions": "4+", "taggedVersions": "4+",
Review Comment:
version should be 3, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org