[GitHub] adoron opened a new pull request #23043: [SPARK-26021][SQL] replace minus zero with zero in Platform.putDouble/Float

[GitBox <gi...@apache.org>]

adoron opened a new pull request #23043: [SPARK-26021][SQL] replace minus zero with zero in Platform.putDouble/Float
URL: https://github.com/apache/spark/pull/23043
 
 
   GROUP BY treats -0.0 and 0.0 as different values which is unlike hive's behavior.
   In addition current behavior with codegen is unpredictable (see example in JIRA ticket).
   
   ## What changes were proposed in this pull request?
   
   In Platform.putDouble/Float() checking if the value is -0.0, and if so replacing with 0.0.
   This is used by UnsafeRow so it won't have -0.0 values.
   
   ## How was this patch tested?
   
   Added tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org