[GitHub] [spark] gengliangwang commented on a change in pull request #25157: [WIP][SPARK-28396][SQL] Add PathCatalog for data source V2

[GitBox <gi...@apache.org>]

gengliangwang commented on a change in pull request #25157: [WIP][SPARK-28396][SQL] Add PathCatalog for data source V2
URL: https://github.com/apache/spark/pull/25157#discussion_r303327682
 
 

 ##########
 File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/Catalogs.java
 ##########
 @@ -50,8 +51,10 @@ private Catalogs() {
    */
   public static CatalogPlugin load(String name, SQLConf conf)
       throws CatalogNotFoundException, SparkException {
-    String pluginClassName = conf.getConfString("spark.sql.catalog." + name, null);
-    if (pluginClassName == null) {
+    String pluginClassName;
 
 Review comment:
   This is a temporary fix for loading session catalog. It might be fixed when there is a conclusion for the conf spark.sql.catalog.session .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org