You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/11/01 20:33:04 UTC
[GitHub] [cloudstack] ezntt opened a new pull request, #6862: Remove password change notice on SSH Key Pair reset
ezntt opened a new pull request, #6862:
URL: https://github.com/apache/cloudstack/pull/6862
### Description
PR #4819 removed the VM password regeneration when assigning a new SSH key pair to the VM; However, still there a message in the UI warning the user that the root's password will be changed after the reset of the SSH Key Pair.
Since this is not the behavior anymore, this part of the message is deprecated.
This PR removes that part of the message in the UI in both language JSONs.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
### How Has This Been Tested?
I applied the changes in a local lab; then, I shut down a VM, and reset the SSH key pair of the VM. The message presented by the UI did not have the warning about the root's password changing.
I also did the tests in the other languages and they were successful.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6862: Remove password change notice on SSH Key Pair reset
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6862:
URL: https://github.com/apache/cloudstack/pull/6862#issuecomment-1299106095
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6862: Remove password change notice on SSH Key Pair reset
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6862:
URL: https://github.com/apache/cloudstack/pull/6862#issuecomment-1307519757
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6862: Remove password change notice on SSH Key Pair reset
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6862:
URL: https://github.com/apache/cloudstack/pull/6862#issuecomment-1299110140
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #6862: Remove password change notice on SSH Key Pair reset
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged PR #6862:
URL: https://github.com/apache/cloudstack/pull/6862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6862: Remove password change notice on SSH Key Pair reset
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6862:
URL: https://github.com/apache/cloudstack/pull/6862#issuecomment-1307520368
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #6862: Remove password change notice on SSH Key Pair reset
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #6862:
URL: https://github.com/apache/cloudstack/pull/6862#issuecomment-1307518944
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6862: Remove password change notice on SSH Key Pair reset
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6862:
URL: https://github.com/apache/cloudstack/pull/6862#issuecomment-1307349701
@ezntt , you have conflicts, can you have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6862: Remove password change notice on SSH Key Pair reset
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6862:
URL: https://github.com/apache/cloudstack/pull/6862#issuecomment-1307614257
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6862)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6862&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6862&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6862&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6862&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6862&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6862&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6862&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6862&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6862&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6862&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6862&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6862&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6862&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6862&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6862: Remove password change notice on SSH Key Pair reset
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6862:
URL: https://github.com/apache/cloudstack/pull/6862#issuecomment-1299109354
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6862: Remove password change notice on SSH Key Pair reset
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6862:
URL: https://github.com/apache/cloudstack/pull/6862#issuecomment-1307530222
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6862: Remove password change notice on SSH Key Pair reset
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6862:
URL: https://github.com/apache/cloudstack/pull/6862#issuecomment-1307529795
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6862: Remove password change notice on SSH Key Pair reset
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6862:
URL: https://github.com/apache/cloudstack/pull/6862#issuecomment-1307523209
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6862: Remove password change notice on SSH Key Pair reset
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6862:
URL: https://github.com/apache/cloudstack/pull/6862#issuecomment-1299170149
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6862?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6862](https://codecov.io/gh/apache/cloudstack/pull/6862?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6205534) into [main](https://codecov.io/gh/apache/cloudstack/commit/fa39e61a4ccd33ccb9b81481eb57c64b3adaf6f7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa39e61) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 6205534 differs from pull request most recent head 43858e2. Consider uploading reports for the commit 43858e2 to get more accurate results
```diff
@@ Coverage Diff @@
## main #6862 +/- ##
=========================================
Coverage 10.84% 10.85%
- Complexity 7104 7106 +2
=========================================
Files 2485 2485
Lines 245417 245417
Branches 38326 38326
=========================================
+ Hits 26627 26631 +4
+ Misses 215521 215517 -4
Partials 3269 3269
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6862?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/cloudstack/syslog/AlertsSyslogAppender.java](https://codecov.io/gh/apache/cloudstack/pull/6862/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hbGVydC1oYW5kbGVycy9zeXNsb2ctYWxlcnRzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N5c2xvZy9BbGVydHNTeXNsb2dBcHBlbmRlci5qYXZh) | `58.75% <0.00%> (+2.25%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6862: Remove password change notice on SSH Key Pair reset
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6862:
URL: https://github.com/apache/cloudstack/pull/6862#issuecomment-1309921814
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6862 (LL-JID-221)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6862: Remove password change notice on SSH Key Pair reset
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6862:
URL: https://github.com/apache/cloudstack/pull/6862#issuecomment-1299105053
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6862: Remove password change notice on SSH Key Pair reset
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6862:
URL: https://github.com/apache/cloudstack/pull/6862#issuecomment-1307524192
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org