[GitHub] [curator] kezhuw commented on pull request #454: CURATOR-666: Fix twice unfixForNamespace in background create

["kezhuw (via GitHub)" <gi...@apache.org>]

kezhuw commented on PR #454:
URL: https://github.com/apache/curator/pull/454#issuecomment-1501129760

   @tison Only `create` has `name`. In zookeeper [async callbacks](https://github.com/apache/zookeeper/blob/3eda8a3a00ef3230d6c16f6ddf9201a3c0f5ca07/zookeeper-server/src/main/java/org/apache/zookeeper/AsyncCallback.java#L209), only `Create2Callback` and `StringCallback`, which both are callback for `ZooKeeper::create`, have `name` parameter. And `unfixForNamespace` is tolerated to `null` input, so I moved it to where we trim `path`. This enable caller to treat them same.
   
   @Randgalt No sure whether it is related, there is [CURATOR-379](https://issues.apache.org/jira/browse/CURATOR-379)(#194), but its test does not convince me either. Though, it is possible for namespace "/zoo" and `getConfig`'s path "/zookeeper/config", but it is another story [ZOOKEEPER-4601](https://issues.apache.org/jira/browse/ZOOKEEPER-4601), [CURATOR-667](https://issues.apache.org/jira/browse/CURATOR-667).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org