[jira] [Commented] (AIRFLOW-6801) Make use of timestamp field in ImportError object

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037384#comment-17037384 ] 

ASF GitHub Bot commented on AIRFLOW-6801:
-----------------------------------------

chrismclennon commented on pull request #7425: [AIRFLOW-6801] Make use of ImportError.timezone
URL: https://github.com/apache/airflow/pull/7425
 
 
   This change makes use of the `ImportError.timestamp` field. When an ImportError is added, the timestamp field is populated with the time that the ImportError was added to the table.
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Make use of timestamp field in ImportError object
> -------------------------------------------------
>
>                 Key: AIRFLOW-6801
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6801
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: models
>    Affects Versions: 1.10.7
>            Reporter: Chris McLennon
>            Assignee: Chris McLennon
>            Priority: Trivial
>
> The ImportError object has a `timestamp` field that goes unused. I believe this field is intended to report when an ImportError has been inserted into the table(?). When we add a row to the import_error table it seems that we should add the current time as the timestamp field as a result.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)