You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "wangkpot (via GitHub)" <gi...@apache.org> on 2023/11/14 06:15:29 UTC

[I] bug: when set upstream.tries = 0, the tcp passive health check will become invalid. [apisix]

wangkpot opened a new issue, #10488:
URL: https://github.com/apache/apisix/issues/10488

   ### Current Behavior
   
   when set upstream.tries = 0, the tcp passive health check will become invalid.
   
   ### Expected Behavior
   
   when set upstream.tries = 0, the tcp passive health check will not become invalid.
   
   ### Error Logs
   
   _No response_
   
   ### Steps to Reproduce
   
   Firstly,set upstream.tries = 0;Secondly,configuring passive health checks for route. Then you will find tcp passive health check will become invalid.
   
   ### Environment
   
   - APISIX version (run `apisix version`):1.19.3
   - Operating system (run `uname -a`):1.19.3
   - OpenResty / Nginx version (run `openresty -V` or `nginx -V`):
   - etcd version, if relevant (run `curl http://127.0.0.1:9090/v1/server_info`):
   - APISIX Dashboard version, if relevant:
   - Plugin runner version, for issues related to plugin runners:
   - LuaRocks version, for installation issues (run `luarocks --version`):
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] bug: when set upstream.tries = 0, the tcp passive health check will become invalid. [apisix]

Posted by "wangkpot (via GitHub)" <gi...@apache.org>.
wangkpot commented on issue #10488:
URL: https://github.com/apache/apisix/issues/10488#issuecomment-1811679292

   > Please provide reproduction steps with the route/upstream configurations that you used.
   
   upstream:
   `{
   		"scheme": "http",
   		"hash_on": "vars",
   		"pass_host": "pass",
   		"checks": {
   			"active": {
   				"type": "tcp",
   				"timeout": 1,
   				"healthy": {
   					"interval": 5,
   					"successes": 2
   				},
   				"unhealthy": {
   					"interval": 3,
   					"tcp_failures": 6
   				}
   			},
   			"passive": {
   				"healthy": {
   					"successes": 2
   				},
   				"type": "tcp",
   				"unhealthy": {
   					"tcp_failures": 2,
   					"timeouts": 1
   				}
   			}
   		},
   		"retries": 0,
   		"nodes": [
   			{
   				"port": 1111,
   				"priority": 0,
   				"host": "xx.xx.xx.xxx",
   				"weight": 99
   			},
   			{
   				"port": 2222,
   				"priority": 0,
   				"host": "xx.xx.xx.xxx",
   				"weight": 99
   			}
   		],
   		"name": "upstream00",
   		"timeout": {
   			"connect": 6,
   			"read": 6,
   			"send": 6
   		},
   		"type": "roundrobin",
   		"id": "upstream00"
   	}`
   route:
   `{
   		"methods": [
   			"GET",
   			"POST",
   			"HEAD"
   		],
   		"hosts": [
   			"common.test.com"
   		],
   		"name": "common",
   		"timeout": {
   			"send": 6,
   			"connect": 6,
   			"read": 6
   		},
   		"priority": 0,
   		"status": 1,
   		"upstream_id": "upstream00",
   		"id": "common",
   		"uris": [
   			"/*"
   		]
   	}`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] bug: when set upstream.tries = 0, the tcp passive health check will become invalid. [apisix]

Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on issue #10488:
URL: https://github.com/apache/apisix/issues/10488#issuecomment-1816021757

   2.13.2 is too old, 3.2 is LTS and 3.6 is latest. Could you check if the recent versions have this problem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] bug: when set upstream.tries = 0, the tcp passive health check will become invalid. [apisix]

Posted by "wangkpot (via GitHub)" <gi...@apache.org>.
wangkpot commented on issue #10488:
URL: https://github.com/apache/apisix/issues/10488#issuecomment-1818377991

   > 2.13.2 is too old, 3.2 is LTS and 3.6 is latest. Could you check if the recent versions have this problem?
   
   I think the latest code still has this problem. You can look at this line of code : https://github.com/apache/apisix/blob/5b7b1de1feeb9f6b5a57c93b13617d7f6dfa68c8/apisix/balancer.lua#L232C29-L232C47 .
   Only when upstream can retry, tcp_failure will be reported.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] bug: when set upstream.tries = 0, the tcp passive health check will become invalid. [apisix]

Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on issue #10488:
URL: https://github.com/apache/apisix/issues/10488#issuecomment-1811809053

   what made you think that the passive healthcheck failed, I could see the nodes marked as healthy. Did you notice any error logs? Am I missing something?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] bug: when set upstream.tries = 0, the tcp passive health check will become invalid. [apisix]

Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on issue #10488:
URL: https://github.com/apache/apisix/issues/10488#issuecomment-1810237048

   Please provide reproduction steps with the route/upstream configurations that you used.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] bug: when set upstream.tries = 0, the tcp passive health check will become invalid. [apisix]

Posted by "wangkpot (via GitHub)" <gi...@apache.org>.
wangkpot commented on issue #10488:
URL: https://github.com/apache/apisix/issues/10488#issuecomment-1813618003

   > what made you think that the passive healthcheck failed, I could see the nodes marked as healthy. Did you notice any error logs? Am I missing something?
   
   The nodes in uptream are  unhealthy, unhealthy nodes will not be removed by tcp passive health checks. You can verify it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] bug: when set upstream.tries = 0, the tcp passive health check will become invalid. [apisix]

Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on issue #10488:
URL: https://github.com/apache/apisix/issues/10488#issuecomment-1813689677

   I tried again, I could see them become unhealthy.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] bug: when set upstream.tries = 0, the tcp passive health check will become invalid. [apisix]

Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on issue #10488:
URL: https://github.com/apache/apisix/issues/10488#issuecomment-1862186084

   @wangkpot have you solved your problem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] bug: when set upstream.tries = 0, the tcp passive health check will become invalid. [apisix]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #10488:
URL: https://github.com/apache/apisix/issues/10488#issuecomment-2514097140

   This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] bug: when set upstream.tries = 0, the tcp passive health check will become invalid. [apisix]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #10488: bug: when set upstream.tries = 0, the tcp passive health check will become invalid.
URL: https://github.com/apache/apisix/issues/10488


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] bug: when set upstream.tries = 0, the tcp passive health check will become invalid. [apisix]

Posted by "wangkpot (via GitHub)" <gi...@apache.org>.
wangkpot commented on issue #10488:
URL: https://github.com/apache/apisix/issues/10488#issuecomment-1815857028

   > > If those node become unhealthy after 18 seconds,that is because active healthcheck.
   > 
   > What does that mean? And what's your APISIX version?
   
   You could see them become unhealthy because active healthcheck marked those nonde as unhealthy, rather than passive healthcheck. My apisix version is 2.13.2.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] bug: when set upstream.tries = 0, the tcp passive health check will become invalid. [apisix]

Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on issue #10488:
URL: https://github.com/apache/apisix/issues/10488#issuecomment-1842757313

   I tried to repro, but failed. Can you give a try?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] bug: when set upstream.tries = 0, the tcp passive health check will become invalid. [apisix]

Posted by "wangkpot (via GitHub)" <gi...@apache.org>.
wangkpot commented on issue #10488:
URL: https://github.com/apache/apisix/issues/10488#issuecomment-1815608113

   > I tried again, I could see them become unhealthy.
   If those node  become unhealthy after 18 seconds,that is because active healthcheck.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] bug: when set upstream.tries = 0, the tcp passive health check will become invalid. [apisix]

Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on issue #10488:
URL: https://github.com/apache/apisix/issues/10488#issuecomment-1815667937

   > If those node become unhealthy after 18 seconds,that is because active healthcheck.
   
   What does that mean? And what's your APISIX version?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] bug: when set upstream.tries = 0, the tcp passive health check will become invalid. [apisix]

Posted by "wangkpot (via GitHub)" <gi...@apache.org>.
wangkpot commented on issue #10488:
URL: https://github.com/apache/apisix/issues/10488#issuecomment-1815613874

   > I tried again, I could see them become unhealthy.
   
   If those node become unhealthy after 18 seconds,that is because active healthcheck.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] bug: when set upstream.tries = 0, the tcp passive health check will become invalid. [apisix]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #10488:
URL: https://github.com/apache/apisix/issues/10488#issuecomment-2550902914

   This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org