You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/05/14 14:45:01 UTC
[GitHub] [rocketmq] mymailmjj opened a new pull request #1993: add body and head length field in RomotingCommand
mymailmjj opened a new pull request #1993:
URL: https://github.com/apache/rocketmq/pull/1993
add body and head length field in RomotingCommand,so they can be get easily when call org.apache.rocketmq.remoting.RPCHook#doAfterResponse
## What is the purpose of the change
to get RomotingCommand head and body length easily
## Brief changelog
add bodyLength and headLength filed and public get method for them
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin edited a comment on pull request #1993: add body and head length field in RomotingCommand
Posted by GitBox <gi...@apache.org>.
RongtongJin edited a comment on pull request #1993:
URL: https://github.com/apache/rocketmq/pull/1993#issuecomment-629102807
If you want to submit a PR You need to do the following things:
Firstly, plz submit related issues to link this PR and explain the purpose of PR according to the format.
Second, you need change the target branch to develop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #1993: add body and head length field in RomotingCommand
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #1993:
URL: https://github.com/apache/rocketmq/pull/1993#issuecomment-628699483
[](https://coveralls.io/builds/30791062)
Coverage increased (+0.03%) to 50.86% when pulling **d03bb19e5dae73cb151cacbb4e04fb8b04d9c018 on mymailmjj:modify_remotecommand** into **8ef01a6c635f6972847c40d5540b1945180d7cbd on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] mymailmjj closed pull request #1993: [ISSUE #2009]add body and head length field in RomotingCommand
Posted by GitBox <gi...@apache.org>.
mymailmjj closed pull request #1993:
URL: https://github.com/apache/rocketmq/pull/1993
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #1993: add body and head length field in RomotingCommand
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1993:
URL: https://github.com/apache/rocketmq/pull/1993#issuecomment-628699483
[](https://coveralls.io/builds/30790615)
Coverage increased (+0.09%) to 50.92% when pulling **d42915b95ddd8da6e6bfa666dab4b918553b7fcd on mymailmjj:modify_remotecommand** into **8ef01a6c635f6972847c40d5540b1945180d7cbd on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #1993: add body and head length field in RomotingCommand
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on pull request #1993:
URL: https://github.com/apache/rocketmq/pull/1993#issuecomment-629102807
Plz create a issue to link the pr before you submit a pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org