You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Ramkumar Vadali (JIRA)" <ji...@apache.org> on 2010/10/21 23:59:18 UTC
[jira] Created: (MAPREDUCE-2146) Raid should not affect access time
of a source file
Raid should not affect access time of a source file
---------------------------------------------------
Key: MAPREDUCE-2146
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2146
Project: Hadoop Map/Reduce
Issue Type: Bug
Reporter: Ramkumar Vadali
Assignee: Ramkumar Vadali
Priority: Minor
After a file is read for creating a raid parity file, the access time should be set back to the value before the read. The read by RAID code is not an application read and should not affect the access time.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-2146) Raid should not affect access time
of a source file
Posted by "Ramkumar Vadali (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramkumar Vadali updated MAPREDUCE-2146:
---------------------------------------
Status: Patch Available (was: Open)
This passes tests.
> Raid should not affect access time of a source file
> ---------------------------------------------------
>
> Key: MAPREDUCE-2146
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2146
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Ramkumar Vadali
> Assignee: Ramkumar Vadali
> Priority: Minor
> Attachments: MAPREDUCE-2146.2.patch, MAPREDUCE-2146.patch
>
>
> After a file is read for creating a raid parity file, the access time should be set back to the value before the read. The read by RAID code is not an application read and should not affect the access time.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-2146) Raid should not affect access
time of a source file
Posted by "Ramkumar Vadali (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924470#action_12924470 ]
Ramkumar Vadali commented on MAPREDUCE-2146:
--------------------------------------------
Test Results:
ant test under src/contrib/raid:
{code}
test-junit:
[junit] WARNING: multiple versions of ant detected in path for junit
[junit] jar:file:/home/rvadali/local/external/ant/lib/ant.jar!/org/apache/tools/ant/Project.class
[junit] and jar:file:/home/rvadali/.ivy2/cache/ant/ant/jars/ant-1.6.5.jar!/org/apache/tools/ant/Project.class
[junit] Running org.apache.hadoop.hdfs.TestRaidDfs
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 29.883 sec
[junit] Running org.apache.hadoop.raid.TestDirectoryTraversal
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 8.962 sec
[junit] Running org.apache.hadoop.raid.TestHarIndexParser
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.052 sec
[junit] Running org.apache.hadoop.raid.TestRaidHar
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 70.91 sec
[junit] Running org.apache.hadoop.raid.TestRaidNode
[junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 404.021 sec
[junit] Running org.apache.hadoop.raid.TestRaidPurge
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 44.224 sec
[junit] Running org.apache.hadoop.raid.TestRaidShell
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 21.06 sec
test:
BUILD SUCCESSFUL
Total time: 9 minutes 58 seconds
{code}
ant test-patch:
{code}
[exec]
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no new tests are needed for this patch.
[exec] Also please list what manual steps were performed to verify this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
[exec] +1 system tests framework. The patch passed system tests framework compile.
[exec]
[exec]
[exec]
[exec]
[exec] ======================================================================
[exec] ======================================================================
[exec] Finished build.
[exec] ======================================================================
[exec] ======================================================================
[exec]
[exec]
{code}
Since this is a one-line fix, I did not add a unit-test
> Raid should not affect access time of a source file
> ---------------------------------------------------
>
> Key: MAPREDUCE-2146
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2146
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Ramkumar Vadali
> Assignee: Ramkumar Vadali
> Priority: Minor
> Attachments: MAPREDUCE-2146.patch
>
>
> After a file is read for creating a raid parity file, the access time should be set back to the value before the read. The read by RAID code is not an application read and should not affect the access time.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-2146) Raid should not affect access time
of a source file
Posted by "Ramkumar Vadali (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramkumar Vadali updated MAPREDUCE-2146:
---------------------------------------
Attachment: MAPREDUCE-2146.patch
One-line fix to set atime on a raided file to the old value.
> Raid should not affect access time of a source file
> ---------------------------------------------------
>
> Key: MAPREDUCE-2146
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2146
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Ramkumar Vadali
> Assignee: Ramkumar Vadali
> Priority: Minor
> Attachments: MAPREDUCE-2146.patch
>
>
> After a file is read for creating a raid parity file, the access time should be set back to the value before the read. The read by RAID code is not an application read and should not affect the access time.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-2146) Raid should not affect access time
of a source file
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated MAPREDUCE-2146:
----------------------------------------
Resolution: Fixed
Fix Version/s: 0.22.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks Ram!
> Raid should not affect access time of a source file
> ---------------------------------------------------
>
> Key: MAPREDUCE-2146
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2146
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Ramkumar Vadali
> Assignee: Ramkumar Vadali
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-2146.2.patch, MAPREDUCE-2146.patch
>
>
> After a file is read for creating a raid parity file, the access time should be set back to the value before the read. The read by RAID code is not an application read and should not affect the access time.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-2146) Raid should not affect access
time of a source file
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926115#action_12926115 ]
Hudson commented on MAPREDUCE-2146:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See [https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/])
> Raid should not affect access time of a source file
> ---------------------------------------------------
>
> Key: MAPREDUCE-2146
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2146
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Ramkumar Vadali
> Assignee: Ramkumar Vadali
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-2146.2.patch, MAPREDUCE-2146.patch
>
>
> After a file is read for creating a raid parity file, the access time should be set back to the value before the read. The read by RAID code is not an application read and should not affect the access time.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-2146) Raid should not affect access time
of a source file
Posted by "Ramkumar Vadali (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramkumar Vadali updated MAPREDUCE-2146:
---------------------------------------
Attachment: MAPREDUCE-2146.2.patch
Added unit-test
> Raid should not affect access time of a source file
> ---------------------------------------------------
>
> Key: MAPREDUCE-2146
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2146
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Ramkumar Vadali
> Assignee: Ramkumar Vadali
> Priority: Minor
> Attachments: MAPREDUCE-2146.2.patch, MAPREDUCE-2146.patch
>
>
> After a file is read for creating a raid parity file, the access time should be set back to the value before the read. The read by RAID code is not an application read and should not affect the access time.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-2146) Raid should not affect access time
of a source file
Posted by "Ramkumar Vadali (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramkumar Vadali updated MAPREDUCE-2146:
---------------------------------------
Status: Open (was: Patch Available)
> Raid should not affect access time of a source file
> ---------------------------------------------------
>
> Key: MAPREDUCE-2146
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2146
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Ramkumar Vadali
> Assignee: Ramkumar Vadali
> Priority: Minor
> Attachments: MAPREDUCE-2146.2.patch, MAPREDUCE-2146.patch
>
>
> After a file is read for creating a raid parity file, the access time should be set back to the value before the read. The read by RAID code is not an application read and should not affect the access time.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-2146) Raid should not affect access time
of a source file
Posted by "Ramkumar Vadali (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramkumar Vadali updated MAPREDUCE-2146:
---------------------------------------
Status: Patch Available (was: Open)
> Raid should not affect access time of a source file
> ---------------------------------------------------
>
> Key: MAPREDUCE-2146
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2146
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Ramkumar Vadali
> Assignee: Ramkumar Vadali
> Priority: Minor
> Attachments: MAPREDUCE-2146.patch
>
>
> After a file is read for creating a raid parity file, the access time should be set back to the value before the read. The read by RAID code is not an application read and should not affect the access time.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-2146) Raid should not affect access
time of a source file
Posted by "Ramkumar Vadali (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925060#action_12925060 ]
Ramkumar Vadali commented on MAPREDUCE-2146:
--------------------------------------------
New Test Resuls:
ant test under src/contrib/raid:
{code}
test-junit:
[junit] WARNING: multiple versions of ant detected in path for junit
[junit] jar:file:/home/rvadali/local/external/ant/lib/ant.jar!/org/apache/tools/ant/Project.class
[junit] and jar:file:/home/rvadali/.ivy2/cache/ant/ant/jars/ant-1.6.5.jar!/org/apache/tools/ant/Project.class
[junit] Running org.apache.hadoop.hdfs.TestRaidDfs
[junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 42.483 sec
[junit] Running org.apache.hadoop.raid.TestDirectoryTraversal
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 8.996 sec
[junit] Running org.apache.hadoop.raid.TestHarIndexParser
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.053 sec
[junit] Running org.apache.hadoop.raid.TestRaidHar
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 70.127 sec
[junit] Running org.apache.hadoop.raid.TestRaidNode
[junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 402.789 sec
[junit] Running org.apache.hadoop.raid.TestRaidPurge
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 44.238 sec
[junit] Running org.apache.hadoop.raid.TestRaidShell
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 26.814 sec
{code}
ant test-patch
{code}
[exec]
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 2 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
[exec] +1 system tests framework. The patch passed system tests framework compile.
[exec]
[exec]
[exec]
[exec]
[exec] ======================================================================
[exec] ======================================================================
[exec] Finished build.
[exec] ======================================================================
[exec] ======================================================================
[exec]
[exec]
BUILD SUCCESSFUL
{code}
> Raid should not affect access time of a source file
> ---------------------------------------------------
>
> Key: MAPREDUCE-2146
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2146
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Ramkumar Vadali
> Assignee: Ramkumar Vadali
> Priority: Minor
> Attachments: MAPREDUCE-2146.2.patch, MAPREDUCE-2146.patch
>
>
> After a file is read for creating a raid parity file, the access time should be set back to the value before the read. The read by RAID code is not an application read and should not affect the access time.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.