You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@yunikorn.apache.org by "Chia-Ping Tsai (Jira)" <ji...@apache.org> on 2024/08/11 20:46:00 UTC

[jira] [Resolved] (YUNIKORN-2724) Improve the signature of methods notifyTaskComplete() and ensureAppAndTaskCreated()

     [ https://issues.apache.org/jira/browse/YUNIKORN-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chia-Ping Tsai resolved YUNIKORN-2724.
--------------------------------------
    Fix Version/s: 1.6.0
       Resolution: Fixed

> Improve the signature of methods notifyTaskComplete() and ensureAppAndTaskCreated()
> -----------------------------------------------------------------------------------
>
>                 Key: YUNIKORN-2724
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2724
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: shim - kubernetes
>            Reporter: Peter Bacsko
>            Assignee: Hsien-Cheng(Ryan) Huang
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> From the review [https://github.com/apache/yunikorn-k8shim/pull/864]
> Change {{notifyTaskComplete(string, string)}} to {{notifyTaskComplete(*Application, string).}} It removes a number of extra getApplication() calls we really do not need.
> Similar for {{ensureAppAndTaskCreated()}} which is only ever called from this function. Add a parameter to it to make it: {{ensureAppAndTaskCreated(*v1.Pod, *Application)}} and only execute application creation {{{}if app == nil{}}}. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org