You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Shazron Abdullah (Created) (JIRA)" <ji...@apache.org> on 2011/11/28 21:45:40 UTC

[jira] [Created] (CB-42) mediaPlaybackRequiresUserAction unable to be set to "NO"

mediaPlaybackRequiresUserAction unable to be set to "NO"
--------------------------------------------------------

                 Key: CB-42
                 URL: https://issues.apache.org/jira/browse/CB-42
             Project: Apache Callback
          Issue Type: Bug
          Components: iOS
            Reporter: Shazron Abdullah


reported at: https://github.com/phonegap/phonegap-iphone/issues/318
by: https://github.com/splendid

It looks like the code that deals with checking the plist and setting the `mediaPlaybackRequiresUserAction` value is incorrect.

it makes the assumption that this value is set to "NO" by default (which is incorrect); and as such does not allow a user to set this value to "NO".

Relevant code: PhoneGapDelegate.m, lines 425-427:

```objective-c
if ([mediaPlaybackRequiresUserAction boolValue] && [self.webView respondsToSelector:@selector(mediaPlaybackRequiresUserAction)]) {
    self.webView.mediaPlaybackRequiresUserAction = YES;
}
```

(Apologies for not submitting a patch myself, I'm still battling #104)


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (CB-42) mediaPlaybackRequiresUserAction unable to be set to "NO"

Posted by "Becky Gibson (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CB-42?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Becky Gibson closed CB-42.
--------------------------

       Resolution: Fixed
    Fix Version/s: 1.4.0
         Assignee: Becky Gibson
    
> mediaPlaybackRequiresUserAction unable to be set to "NO"
> --------------------------------------------------------
>
>                 Key: CB-42
>                 URL: https://issues.apache.org/jira/browse/CB-42
>             Project: Apache Callback
>          Issue Type: Bug
>          Components: iOS
>            Reporter: Shazron Abdullah
>            Assignee: Becky Gibson
>             Fix For: 1.4.0
>
>
> reported at: https://github.com/phonegap/phonegap-iphone/issues/318
> by: https://github.com/splendid
> It looks like the code that deals with checking the plist and setting the `mediaPlaybackRequiresUserAction` value is incorrect.
> it makes the assumption that this value is set to "NO" by default (which is incorrect); and as such does not allow a user to set this value to "NO".
> Relevant code: PhoneGapDelegate.m, lines 425-427:
> ```objective-c
> if ([mediaPlaybackRequiresUserAction boolValue] && [self.webView respondsToSelector:@selector(mediaPlaybackRequiresUserAction)]) {
>     self.webView.mediaPlaybackRequiresUserAction = YES;
> }
> ```
> (Apologies for not submitting a patch myself, I'm still battling #104)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CB-42) mediaPlaybackRequiresUserAction unable to be set to "NO"

Posted by "Becky Gibson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190137#comment-13190137 ] 

Becky Gibson commented on CB-42:
--------------------------------

fixed with this commit:  https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=commit;h=f60c315c262439f4acea74ca07b81933fe0a0b2a
                
> mediaPlaybackRequiresUserAction unable to be set to "NO"
> --------------------------------------------------------
>
>                 Key: CB-42
>                 URL: https://issues.apache.org/jira/browse/CB-42
>             Project: Apache Callback
>          Issue Type: Bug
>          Components: iOS
>            Reporter: Shazron Abdullah
>             Fix For: 1.4.0
>
>
> reported at: https://github.com/phonegap/phonegap-iphone/issues/318
> by: https://github.com/splendid
> It looks like the code that deals with checking the plist and setting the `mediaPlaybackRequiresUserAction` value is incorrect.
> it makes the assumption that this value is set to "NO" by default (which is incorrect); and as such does not allow a user to set this value to "NO".
> Relevant code: PhoneGapDelegate.m, lines 425-427:
> ```objective-c
> if ([mediaPlaybackRequiresUserAction boolValue] && [self.webView respondsToSelector:@selector(mediaPlaybackRequiresUserAction)]) {
>     self.webView.mediaPlaybackRequiresUserAction = YES;
> }
> ```
> (Apologies for not submitting a patch myself, I'm still battling #104)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira