You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/05/17 20:24:49 UTC
[GitHub] [incubator-hudi] jfrazee opened a new pull request #1639: [MINOR] Fix apache-rat violations
jfrazee opened a new pull request #1639:
URL: https://github.com/apache/incubator-hudi/pull/1639
This fixes a few apache-rat violations and adds exclusions for the GitHub PR template type stuff. Note there is already a general attribution for Twitter in the NOTICE so I don't think we need to add another.
```
hudi-common/src/main/java/org/apache/hudi/common/util/ObjectSizeCalculator.java
hudi-utilities/src/main/java/org/apache/hudi/utilities/exception/HoodieSnapshotExporterException.java
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestInputBatch.java
.github/**
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-io edited a comment on pull request #1639: [MINOR] Fix apache-rat violations
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1639:
URL: https://github.com/apache/incubator-hudi/pull/1639#issuecomment-629859704
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1639?src=pr&el=h1) Report
> Merging [#1639](https://codecov.io/gh/apache/incubator-hudi/pull/1639?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/25a0080b2f6ddce0e528b2a72aea33a565f0e565&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1639?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1639 +/- ##
============================================
+ Coverage 16.71% 16.72% +0.01%
- Complexity 795 796 +1
============================================
Files 340 340
Lines 15030 15030
Branches 1499 1499
============================================
+ Hits 2512 2514 +2
+ Misses 12188 12186 -2
Partials 330 330
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1639?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/hudi/common/util/ObjectSizeCalculator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1639/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3V0aWwvT2JqZWN0U2l6ZUNhbGN1bGF0b3IuamF2YQ==) | `77.61% <ø> (ø)` | `25.00 <0.00> (ø)` | |
| [...apache/hudi/common/fs/HoodieWrapperFileSystem.java](https://codecov.io/gh/apache/incubator-hudi/pull/1639/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0hvb2RpZVdyYXBwZXJGaWxlU3lzdGVtLmphdmE=) | `22.69% <0.00%> (+0.70%)` | `29.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1639?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1639?src=pr&el=footer). Last update [25a0080...b50fc84](https://codecov.io/gh/apache/incubator-hudi/pull/1639?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] codecov-io commented on pull request #1639: [MINOR] Fix apache-rat violations
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1639:
URL: https://github.com/apache/incubator-hudi/pull/1639#issuecomment-629859704
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1639?src=pr&el=h1) Report
> Merging [#1639](https://codecov.io/gh/apache/incubator-hudi/pull/1639?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/25a0080b2f6ddce0e528b2a72aea33a565f0e565&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1639?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1639 +/- ##
============================================
+ Coverage 16.71% 16.72% +0.01%
- Complexity 795 796 +1
============================================
Files 340 340
Lines 15030 15030
Branches 1499 1499
============================================
+ Hits 2512 2514 +2
+ Misses 12188 12186 -2
Partials 330 330
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1639?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/hudi/common/util/ObjectSizeCalculator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1639/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3V0aWwvT2JqZWN0U2l6ZUNhbGN1bGF0b3IuamF2YQ==) | `77.61% <ø> (ø)` | `25.00 <0.00> (ø)` | |
| [...apache/hudi/common/fs/HoodieWrapperFileSystem.java](https://codecov.io/gh/apache/incubator-hudi/pull/1639/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0hvb2RpZVdyYXBwZXJGaWxlU3lzdGVtLmphdmE=) | `22.69% <0.00%> (+0.70%)` | `29.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1639?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1639?src=pr&el=footer). Last update [25a0080...b50fc84](https://codecov.io/gh/apache/incubator-hudi/pull/1639?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] bvaradar commented on pull request #1639: [MINOR] Fix apache-rat violations
Posted by GitBox <gi...@apache.org>.
bvaradar commented on pull request #1639:
URL: https://github.com/apache/incubator-hudi/pull/1639#issuecomment-630352568
@vinothchandar : Added rat check to hudi-integ-test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] vinothchandar commented on pull request #1639: [MINOR] Fix apache-rat violations
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #1639:
URL: https://github.com/apache/incubator-hudi/pull/1639#issuecomment-630072442
@bvaradar `hudi-integ-test` also does not list the rat plugin.. Might be good to add these to bundles as well, just in case. (our release script will catch all this.. however good to do upfront)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] bvaradar merged pull request #1639: [MINOR] Fix apache-rat violations
Posted by GitBox <gi...@apache.org>.
bvaradar merged pull request #1639:
URL: https://github.com/apache/incubator-hudi/pull/1639
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] bvaradar commented on pull request #1639: [MINOR] Fix apache-rat violations
Posted by GitBox <gi...@apache.org>.
bvaradar commented on pull request #1639:
URL: https://github.com/apache/incubator-hudi/pull/1639#issuecomment-629958724
@jfrazee : Thanks a lot for your help in identifying and providing the fix. There is one more related change as part of this and I took the liberty to add the patch to this PR. If the tests goes fine, I will merge the combined changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] bvaradar commented on pull request #1639: [MINOR] Fix apache-rat violations
Posted by GitBox <gi...@apache.org>.
bvaradar commented on pull request #1639:
URL: https://github.com/apache/incubator-hudi/pull/1639#issuecomment-629957097
For the other classes, the underlying problem is that apache-rat was not enabled for hudi-utilities bundle
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org