You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/18 13:33:10 UTC
[GitHub] [spark] santosh-d3vpl3x opened a new pull request, #37571: [SPARK-21487][UI] Change extension of mustache template files to .mustache
santosh-d3vpl3x opened a new pull request, #37571:
URL: https://github.com/apache/spark/pull/37571
### What changes were proposed in this pull request?
Change extension of mustache template files to .mustache from .html.
### Why are the changes needed?
Kerberised yarn applies auth filter twice on .html files causing `Request is a replay (34)`. This leads to blank pages in Spark UI and users are mostly left with a lot of guess work.
### Does this PR introduce _any_ user-facing change?
for kerberised clusters, the executors and stages pages should start working again.
### How was this patch tested?
Two ways:
- Ran spark locally and in kerberised cluster with and without knox. verify that it works. ✅
- Test cases in this CI. <- We will get to know at the end of CI run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #37571: [SPARK-21487][CORE][WEB UI] Change extension of mustache template files to .mustache
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #37571: [SPARK-21487][CORE][WEB UI] Change extension of mustache template files to .mustache
URL: https://github.com/apache/spark/pull/37571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] santosh-d3vpl3x commented on pull request #37571: [SPARK-21487][CORE][WEB UI] Change extension of mustache template files to .mustache
Posted by GitBox <gi...@apache.org>.
santosh-d3vpl3x commented on PR #37571:
URL: https://github.com/apache/spark/pull/37571#issuecomment-1221920844
Would one of you like to have a look @gengliangwang @LuciferYang?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] santosh-d3vpl3x commented on pull request #37571: [SPARK-21487][CORE][WEB UI] Change extension of mustache template files to .mustache
Posted by GitBox <gi...@apache.org>.
santosh-d3vpl3x commented on PR #37571:
URL: https://github.com/apache/spark/pull/37571#issuecomment-1219552995
> Hm, are they 'mustache templates'? they seem like plain old HTML files.
Thats how they are treated at present even though couple of them don't really contain any templatised variables.
```js
var apps = $(Mustache.render($(template).filter("#history-summary-template").html(),data));
```
```js
tasksSummary.append(Mustache.render($(template).filter("#stages-summary-template").html()));
```
```js
executorsSummary.append(Mustache.render($(template).filter("#executors-summary-template").html(), data));
```
>I don't have a specific concern, but concerned about changing the extension breaking something else that won't know to interpret this as HTML? probalby not an issue
I static handler part in spark on server side and the renderer on client, couldn't find anything concerning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #37571: [SPARK-21487][CORE][WEB UI] Change extension of mustache template files to .mustache
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #37571:
URL: https://github.com/apache/spark/pull/37571#issuecomment-1219541122
Hm, are they 'mustache templates'? they seem like plain old HTML files. I don't have a specific concern, but concerned about changing the extension breaking something else that won't know to interpret this as HTML? probalby not an issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #37571: [SPARK-21487][CORE][WEB UI] Change extension of mustache template files to .mustache
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #37571:
URL: https://github.com/apache/spark/pull/37571#issuecomment-1219512462
It's not a troublesome change, but seems hacky. Is there no way to fix the auth filter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #37571: [SPARK-21487][CORE][WEB UI] Change extension of mustache template files to .mustache
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #37571:
URL: https://github.com/apache/spark/pull/37571#issuecomment-1332933243
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #37571: [SPARK-21487][CORE][WEB UI] Change extension of mustache template files to .mustache
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #37571:
URL: https://github.com/apache/spark/pull/37571#issuecomment-1220343494
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] santosh-d3vpl3x commented on pull request #37571: [SPARK-21487][CORE][WEB UI] Change extension of mustache template files to .mustache
Posted by GitBox <gi...@apache.org>.
santosh-d3vpl3x commented on PR #37571:
URL: https://github.com/apache/spark/pull/37571#issuecomment-1219519576
> It's not a troublesome change, but seems hacky. Is there no way to fix the auth filter?
I have seen a few attempts but not sure if it actually ever worked, we went through hadoop upgrades in hope that closed tickets on hadoop/yarn side would fix the issue but it proved to be futile.
Also, `.html` is a wrong extension for mustache template files for beginners. Mustache repo advertises `.mustache` as a correct extension. So not sure if it is really all that hacky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org