You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "SBIN2010 (via GitHub)" <gi...@apache.org> on 2025/03/18 14:20:43 UTC
[I] Annotation layers are not imported/exported. [superset]
SBIN2010 opened a new issue, #32722:
URL: https://github.com/apache/superset/issues/32722
### Bug description
Hi! Since version 3.1.1 import of annotation layers of all types except AnnotationType.FORMULA stopped working.
The import has a filter_chart_annotations stub which filters out all annotation types except FORMULA.
Also if charts are used as annotation layers they are not included in the export.
### Screenshots/recordings
_No response_
### Superset version
4.1.1
### Python version
3.9
### Node version
16
### Browser
Chrome
### Additional context
_No response_
### Checklist
- [ ] I have searched Superset docs and Slack and didn't find a solution to my problem.
- [ ] I have searched the GitHub issue tracker and didn't find a similar bug report.
- [ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Annotation layers are not imported/exported. [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #32722:
URL: https://github.com/apache/superset/issues/32722#issuecomment-5768548394
Still tracked via #43232 - left review feedback there on the 10th, it just needs the rebase (bot's already flagging conflicts against `master`) plus those items addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Annotation layers are not imported/exported. [superset]
Posted by "EnxDev (via GitHub)" <gi...@apache.org>.
EnxDev closed issue #32722: Annotation layers are not imported/exported.
URL: https://github.com/apache/superset/issues/32722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Annotation layers are not imported/exported. [superset]
Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #32722:
URL: https://github.com/apache/superset/issues/32722#issuecomment-2733443663
<!-- Answer -->
Annotation layers, except for `AnnotationType.FORMULA`, are not being imported or exported in Superset version 4.1.1 because the `filter_chart_annotations` function explicitly filters out all annotation layers that are not of type `FORMULA`. This behavior was introduced in version 3.1.1 as a temporary measure, as indicated by a TODO comment in the code suggesting the need to handle annotation dependencies on other charts or annotation layer objects <sup>[[1]](https://github.com/apache/superset/blob/master/superset/commands/chart/importers/v1/utils.py)</sup><sup>[[2]](https://github.com/apache/superset/blob/master/CHANGELOG/3.1.1.md)</sup>.
<!-- Dosu Comment Footer -->
*To continue talking to [Dosu](https://dosu.dev), mention @dosu.*
---
<sup>Help Dosu learn! Give it feedback: [Great Response](https://app.dosu.dev/response-feedback/88668e02-7571-4711-80d8-15f4ec52a724?feedback_type=great_response) | [Irrelevant Answer](https://app.dosu.dev/response-feedback/88668e02-7571-4711-80d8-15f4ec52a724?feedback_type=irrelevant_answer) | [Incorrect Sources](https://app.dosu.dev/response-feedback/88668e02-7571-4711-80d8-15f4ec52a724?feedback_type=incorrect_sources) | [Too Verbose](https://app.dosu.dev/response-feedback/88668e02-7571-4711-80d8-15f4ec52a724?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/88668e02-7571-4711-80d8-15f4ec52a724?feedback_type=hallucination) | [Bug Report](https://app.dosu.dev/response-feedback/88668e02-7571-4711-80d8-15f4ec52a724?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/88668e02-7571-4711-80d8-15f4ec52a724?feedback_type=other)</sup>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Annotation layers are not imported/exported. [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #32722:
URL: https://github.com/apache/superset/issues/32722#issuecomment-5053217512
@MallikarjunaReddyN #39857 looks close, but it's carrying merge conflicts and a couple red checks — mind rebasing on master and getting CI green? Happy to line up a review once it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Annotation layers are not imported/exported. [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #32722:
URL: https://github.com/apache/superset/issues/32722#issuecomment-2971839078
Honeslty, not sure if anyone's really on the case for this. PRs/investigation more than welcomed, but this is not prioritzed. Annotation Layers are one of those due-for-a-revamp backlog items.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Annotation layers are not imported/exported. [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #32722:
URL: https://github.com/apache/superset/issues/32722#issuecomment-4035396106
Per @rusackas, Annotation Layers are on the backlog for a revamp and this export/import gap is a known gap. PRs are welcome. Leaving open as a known issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org