You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/19 07:24:49 UTC
[GitHub] [shardingsphere-elasticjob] m1ngyuan opened a new pull request, #2087: Merge similar GitHub Actions workflow files #2083
m1ngyuan opened a new pull request, #2087:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2087
Fixes #2083.
Changes proposed in this pull request:
- Merge similar GitHub Actions workflow files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on a diff in pull request #2087: Merge similar GitHub Actions workflow files #2083
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on code in PR #2087:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2087#discussion_r876709648
##########
pom.xml:
##########
@@ -705,6 +705,12 @@
</pluginManagement>
</build>
</profile>
+ <profile>
Review Comment:
> -Dmaven.javadoc.skip=true on windows will be fail
Why? Could you check it again? I think it doesn't make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on a diff in pull request #2087: Merge similar GitHub Actions workflow files #2083
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on code in PR #2087:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2087#discussion_r876702723
##########
pom.xml:
##########
@@ -705,6 +705,12 @@
</pluginManagement>
</build>
</profile>
+ <profile>
Review Comment:
What's the different with `-Dmaven.javadoc.skip=true`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] m1ngyuan commented on a diff in pull request #2087: Merge similar GitHub Actions workflow files #2083
Posted by GitBox <gi...@apache.org>.
m1ngyuan commented on code in PR #2087:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2087#discussion_r876751538
##########
pom.xml:
##########
@@ -705,6 +705,12 @@
</pluginManagement>
</build>
</profile>
+ <profile>
Review Comment:
Thank you for your advice,I found a solution to the problem,Please trigger GitHub workflow again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] m1ngyuan commented on a diff in pull request #2087: Merge similar GitHub Actions workflow files #2083
Posted by GitBox <gi...@apache.org>.
m1ngyuan commented on code in PR #2087:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2087#discussion_r876704579
##########
pom.xml:
##########
@@ -705,6 +705,12 @@
</pluginManagement>
</build>
</profile>
+ <profile>
Review Comment:
-Dmaven.javadoc.skip=true on windows will be fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #2087: Merge similar GitHub Actions workflow files #2083
Posted by GitBox <gi...@apache.org>.
TeslaCN merged PR #2087:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org