You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Michael Neale (JIRA)" <ji...@apache.org> on 2006/09/07 13:22:23 UTC
[jira] Created: (JCR-564) Remove geronimo JTA as a runtime
dependency
Remove geronimo JTA as a runtime dependency
-------------------------------------------
Key: JCR-564
URL: http://issues.apache.org/jira/browse/JCR-564
Project: Jackrabbit
Issue Type: Bug
Components: maven
Affects Versions: 1.0.1
Reporter: Michael Neale
Priority: Critical
Geronimo JTA is marked as a dependency for runtime when it should be (at most) a compile time dependency.
Is it possible to remedy this so when using the war or building your own, you don't get the geronimo jar stowing away?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JCR-564) Remove geronimo JTA as a runtime
dependency
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-564:
------------------------------
Component/s: transactions
jackrabbit-core
Affects Version/s: (was: 1.0.1)
> Remove geronimo JTA as a runtime dependency
> -------------------------------------------
>
> Key: JCR-564
> URL: https://issues.apache.org/jira/browse/JCR-564
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core, maven, transactions
> Reporter: Michael Neale
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: 1.4
>
> Attachments: jta.patch
>
>
> Geronimo JTA is marked as a dependency for runtime when it should be (at most) a compile time dependency.
> Is it possible to remedy this so when using the war or building your own, you don't get the geronimo jar stowing away?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-564) Remove geronimo JTA as a runtime
dependency
Posted by "Dominique Pfister (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-564?page=comments#action_12433106 ]
Dominique Pfister commented on JCR-564:
---------------------------------------
You're right: some classes are actually contained in a JDK's/JRE's rt.jar (1.4 or higher). The operations leaving that scope are the tests related to XA functionality: particularly o.a.j.core.UserTransactionImpl working as dummy javax.xa.UserTransaction, an interface that is not contained in the JRE's rt.jar. Therefore, I don't think, removing the dependency to geronimo-spec-jta is an option.
> Remove geronimo JTA as a runtime dependency
> -------------------------------------------
>
> Key: JCR-564
> URL: http://issues.apache.org/jira/browse/JCR-564
> Project: Jackrabbit
> Issue Type: Bug
> Components: maven
> Affects Versions: 1.0.1
> Reporter: Michael Neale
> Priority: Critical
>
> Geronimo JTA is marked as a dependency for runtime when it should be (at most) a compile time dependency.
> Is it possible to remedy this so when using the war or building your own, you don't get the geronimo jar stowing away?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JCR-564) Remove geronimo JTA as a runtime
dependency
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-564?page=all ]
Jukka Zitting updated JCR-564:
------------------------------
Issue Type: Improvement (was: Bug)
Priority: Minor (was: Critical)
> Remove geronimo JTA as a runtime dependency
> -------------------------------------------
>
> Key: JCR-564
> URL: http://issues.apache.org/jira/browse/JCR-564
> Project: Jackrabbit
> Issue Type: Improvement
> Components: maven
> Affects Versions: 1.0.1
> Reporter: Michael Neale
> Priority: Minor
>
> Geronimo JTA is marked as a dependency for runtime when it should be (at most) a compile time dependency.
> Is it possible to remedy this so when using the war or building your own, you don't get the geronimo jar stowing away?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (JCR-564) Remove geronimo JTA as a runtime
dependency
Posted by "Michael Neale (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-564?page=comments#action_12433100 ]
Michael Neale commented on JCR-564:
-----------------------------------
yeah that would be it, OK no problems.
I was able to run it stand alone with no JTA on the classpath just fine, there must only be some operations which would touch it at runtime ?
I assume the standard JTA would do just fine (and like you said, can be removed when in an appropriate container anyway).
> Remove geronimo JTA as a runtime dependency
> -------------------------------------------
>
> Key: JCR-564
> URL: http://issues.apache.org/jira/browse/JCR-564
> Project: Jackrabbit
> Issue Type: Bug
> Components: maven
> Affects Versions: 1.0.1
> Reporter: Michael Neale
> Priority: Critical
>
> Geronimo JTA is marked as a dependency for runtime when it should be (at most) a compile time dependency.
> Is it possible to remedy this so when using the war or building your own, you don't get the geronimo jar stowing away?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (JCR-564) Remove geronimo JTA as a runtime
dependency
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting resolved JCR-564.
-------------------------------
Resolution: Fixed
Fix Version/s: 1.4
Patch committed in revision 582264.
> Remove geronimo JTA as a runtime dependency
> -------------------------------------------
>
> Key: JCR-564
> URL: https://issues.apache.org/jira/browse/JCR-564
> Project: Jackrabbit
> Issue Type: Improvement
> Components: maven
> Affects Versions: 1.0.1
> Reporter: Michael Neale
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: 1.4
>
> Attachments: jta.patch
>
>
> Geronimo JTA is marked as a dependency for runtime when it should be (at most) a compile time dependency.
> Is it possible to remedy this so when using the war or building your own, you don't get the geronimo jar stowing away?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-564) Remove geronimo JTA as a runtime
dependency
Posted by "Michael Neale (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-564?page=comments#action_12433118 ]
Michael Neale commented on JCR-564:
-----------------------------------
OK, in maven 2 you can mark it as "provided" which means it is a compile/test time dep, but at runtime it is expected to be provided by the container - not sure if maven 1 has the equivalent.
> Remove geronimo JTA as a runtime dependency
> -------------------------------------------
>
> Key: JCR-564
> URL: http://issues.apache.org/jira/browse/JCR-564
> Project: Jackrabbit
> Issue Type: Bug
> Components: maven
> Affects Versions: 1.0.1
> Reporter: Michael Neale
> Priority: Critical
>
> Geronimo JTA is marked as a dependency for runtime when it should be (at most) a compile time dependency.
> Is it possible to remedy this so when using the war or building your own, you don't get the geronimo jar stowing away?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (JCR-564) Remove geronimo JTA as a runtime
dependency
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting reassigned JCR-564:
---------------------------------
Assignee: Jukka Zitting
> Remove geronimo JTA as a runtime dependency
> -------------------------------------------
>
> Key: JCR-564
> URL: https://issues.apache.org/jira/browse/JCR-564
> Project: Jackrabbit
> Issue Type: Improvement
> Components: maven
> Affects Versions: 1.0.1
> Reporter: Michael Neale
> Assignee: Jukka Zitting
> Priority: Minor
>
> Geronimo JTA is marked as a dependency for runtime when it should be (at most) a compile time dependency.
> Is it possible to remedy this so when using the war or building your own, you don't get the geronimo jar stowing away?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-564) Remove geronimo JTA as a runtime
dependency
Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-564?page=comments#action_12433686 ]
Tobias Bocanegra commented on JCR-564:
--------------------------------------
> OK, in maven 2 you can mark it as "provided" which means it is a compile/test time dep, but at
> runtime it is expected to be provided by the container
exactly.
> - not sure if maven 1 has the equivalent.
unfortunately not, but the similar functionality is built using the 'war.bundle' property.
> Remove geronimo JTA as a runtime dependency
> -------------------------------------------
>
> Key: JCR-564
> URL: http://issues.apache.org/jira/browse/JCR-564
> Project: Jackrabbit
> Issue Type: Bug
> Components: maven
> Affects Versions: 1.0.1
> Reporter: Michael Neale
> Priority: Critical
>
> Geronimo JTA is marked as a dependency for runtime when it should be (at most) a compile time dependency.
> Is it possible to remedy this so when using the war or building your own, you don't get the geronimo jar stowing away?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (JCR-564) Remove geronimo JTA as a runtime
dependency
Posted by "Dominique Pfister (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-564?page=comments#action_12433095 ]
Dominique Pfister commented on JCR-564:
---------------------------------------
You probably allude to the following lines in jackrabbit/trunk/jcr-server/webapp/project.xml:
<dependency>
<groupId>geronimo-spec</groupId>
<artifactId>geronimo-spec-jta</artifactId>
<version>1.0-M1</version>
<properties>
<war.bundle>true</war.bundle>
</properties>
</dependency>
Actually, Jackrabbit's session implementation o.a.j.core.XASessionImpl references XAResource from the javax.transaction.xa package. Being of course a mandatory part of an application server, this jar has been included in the web application when used in servlet container environments, where it is optional. If you still need the "geronimo-free" web application, changing the value of the property "war.bundle" to "false" in your local copy should do the trick.
> Remove geronimo JTA as a runtime dependency
> -------------------------------------------
>
> Key: JCR-564
> URL: http://issues.apache.org/jira/browse/JCR-564
> Project: Jackrabbit
> Issue Type: Bug
> Components: maven
> Affects Versions: 1.0.1
> Reporter: Michael Neale
> Priority: Critical
>
> Geronimo JTA is marked as a dependency for runtime when it should be (at most) a compile time dependency.
> Is it possible to remedy this so when using the war or building your own, you don't get the geronimo jar stowing away?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JCR-564) Remove geronimo JTA as a runtime
dependency
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-564:
------------------------------
Attachment: jta.patch
Interesting, we actually had an existing issue for the change that was recently discussed on the mailing list [1].
The attached patch changes the scope of the geronimo-jta dependency from compile to test within jackrabbit-core. The only required code changes are about copying a few private transaction status constants. In fact, looking at the code flow, the status codes are mostly unused, and could easily be replaced with two boolean flags (prepared & rolledBack). However, in order to keep this patch strictly non-functional, I didn't include such changes.
I haven't yet looked at how this change affects downstream components like jackrabbit-jca.
[1] http://www.nabble.com/Using-the-geronimo-jta-dependency-only-in-test-scope-tf4466162.html
> Remove geronimo JTA as a runtime dependency
> -------------------------------------------
>
> Key: JCR-564
> URL: https://issues.apache.org/jira/browse/JCR-564
> Project: Jackrabbit
> Issue Type: Improvement
> Components: maven
> Affects Versions: 1.0.1
> Reporter: Michael Neale
> Assignee: Jukka Zitting
> Priority: Minor
> Attachments: jta.patch
>
>
> Geronimo JTA is marked as a dependency for runtime when it should be (at most) a compile time dependency.
> Is it possible to remedy this so when using the war or building your own, you don't get the geronimo jar stowing away?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.