[GitHub] [pinot] richardstartin commented on pull request #8457: add tracing SPI

[GitBox <gi...@apache.org>]

richardstartin commented on pull request #8457:
URL: https://github.com/apache/pinot/pull/8457#issuecomment-1086133603


   > Huge +1
   > 
   > Thanks @richardstartin . I will review the approach today. Meanwhile, wanted to check on one thing:
   > 
   > We had added the threadCpuTime metric (measured at the server combine level). As part of the [next work for EXPLAIN PLAN](https://docs.google.com/document/d/1lBMGcR65JY_8iIUCA1iCazzn0LzTVxMJlPzFIsZ7TRk/edit#heading=h.kwlkkfaymsj0), we wanted to push down the measurement of this metric (or at least evaluate if it is feasible to do so) and other metrics at the lower / leaf operator level as well with the goal of creating a QueryProfile / Operator level stats.
   > 
   > I am guessing the new abstraction proposed in this PR will allow us to do so. Just want to make sure it won't prevent us from doing so and this can be further extended
   
   The idea is to be able to implement that sort of thing at the operator layer, yes. The main goal is to not need to agree what gets recorded in a span or how. This design also leaves context propagation up to the implementor, who can choose between bytecode instrumentation (which allows propagation of arbitrary information) and the existing, rather limited, mechanism.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org