You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "big-r81 (via GitHub)" <gi...@apache.org> on 2023/12/30 14:34:41 UTC
[PR] feat(docs): Set docs version numbers dynamically from file [couchdb]
big-r81 opened a new pull request, #4933:
URL: https://github.com/apache/couchdb/pull/4933
Load documentation version from local version.mk file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(docs/3.3.x): Set docs version numbers dynamically from file [couchdb]
Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on code in PR #4933:
URL: https://github.com/apache/couchdb/pull/4933#discussion_r1438687396
##########
src/docs/src/conf.py:
##########
@@ -29,9 +30,13 @@
nitpicky = True
-# should be over-written using rebar-inherited settings
-version = "3.3"
-release = "3.3.0"
+# load version numbers from version.mk
+version_file = Path().absolute().joinpath('../../../version.mk').resolve()
+with open(version_file) as file:
+ props = dict(line.strip().split('=', 1) for line in file)
+
+version = f"{props['vsn_major']}.{props['vsn_minor']}" #"3.3"
+release = f"{props['vsn_major']}.{props['vsn_minor']}.{props['vsn_patch']}" #"3.3.3"
Review Comment:
I have removed it. In the beginning it was meant to be easier to read, but it might just lead to confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(docs/3.3.x): Set docs version numbers dynamically from file [couchdb]
Posted by "jaydoane (via GitHub)" <gi...@apache.org>.
jaydoane commented on code in PR #4933:
URL: https://github.com/apache/couchdb/pull/4933#discussion_r1438671564
##########
src/docs/src/conf.py:
##########
@@ -29,9 +30,13 @@
nitpicky = True
-# should be over-written using rebar-inherited settings
-version = "3.3"
-release = "3.3.0"
+# load version numbers from version.mk
+version_file = Path().absolute().joinpath('../../../version.mk').resolve()
+with open(version_file) as file:
+ props = dict(line.strip().split('=', 1) for line in file)
+
+version = f"{props['vsn_major']}.{props['vsn_minor']}" #"3.3"
+release = f"{props['vsn_major']}.{props['vsn_minor']}.{props['vsn_patch']}" #"3.3.3"
Review Comment:
Do you want to leave the comments in place, which will become obsolete as soon as there's a new release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(docs/3.3.x): Set docs version numbers dynamically from file [couchdb]
Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on PR #4933:
URL: https://github.com/apache/couchdb/pull/4933#issuecomment-1872909961
**REMINDER**
`erlfmt` IS NOT `python-black`.
`erlfmt` IS NOT `python-black`.
`erlfmt` IS NOT `python-black`.
`erlfmt` IS NOT `python-black`.
Thx, @jaydoane π π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(docs/3.3.x): Set docs version numbers dynamically from file [couchdb]
Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 merged PR #4933:
URL: https://github.com/apache/couchdb/pull/4933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(docs/3.3.x): Set docs version numbers dynamically from file [couchdb]
Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on PR #4933:
URL: https://github.com/apache/couchdb/pull/4933#issuecomment-1872608862
Getting this python-black error, which I canβt reproduce locally. Should I merge it anyway or do you have any tips?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(docs/3.3.x): Set docs version numbers dynamically from file [couchdb]
Posted by "jaydoane (via GitHub)" <gi...@apache.org>.
jaydoane commented on code in PR #4933:
URL: https://github.com/apache/couchdb/pull/4933#discussion_r1438719229
##########
src/docs/src/conf.py:
##########
@@ -29,9 +30,13 @@
nitpicky = True
-# should be over-written using rebar-inherited settings
-version = "3.3"
-release = "3.3.0"
+# load version numbers from version.mk
+version_file = Path().absolute().joinpath('../../../version.mk').resolve()
+with open(version_file) as file:
+ props = dict(line.strip().split('=', 1) for line in file)
Review Comment:
`black` also complains about the single quotes around the equal sign. Try changing to `"="`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(docs/3.3.x): Set docs version numbers dynamically from file [couchdb]
Posted by "jaydoane (via GitHub)" <gi...@apache.org>.
jaydoane commented on code in PR #4933:
URL: https://github.com/apache/couchdb/pull/4933#discussion_r1438719029
##########
src/docs/src/conf.py:
##########
@@ -29,9 +30,13 @@
nitpicky = True
-# should be over-written using rebar-inherited settings
-version = "3.3"
-release = "3.3.0"
+# load version numbers from version.mk
+version_file = Path().absolute().joinpath('../../../version.mk').resolve()
Review Comment:
I'm seeing `black` complain about the single quotes around `'../../../version.mk'`.
`make python-black-update` changes it to double quotes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org