You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2009/01/05 20:23:44 UTC
[jira] Issue Comment Edited: (LUCENE-1504) SerialChainFilter should
use DocSet API rather then deprecated BitSet API
[ https://issues.apache.org/jira/browse/LUCENE-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660864#action_12660864 ]
thetaphi edited comment on LUCENE-1504 at 1/5/09 11:22 AM:
----------------------------------------------------------------
Hi Patrick,
as the spatial contrib was included into Lucene after 2.4 where the old API is already deprecated, there is no need to implement bits() at all. Just leave the default, that get removed on 3.0. As the code was not released before the deprecation, there would be nobody using it and it does not make sense to add APIs that are deprecated from the beginning.
TrieRangeFilter was also included after the change and never implemented bits() [it implemented it in the past, but at this time it was in another package outside of lucene, so deprecation is out of responsibility for lucene].
Paul:
bq. In case you prefer to use one of these, a dependency on the corresponding contrib module may have to be added in the build process of the spatial contrib.
Very interesting, on thinking about how to include TrieRangeQuery with spatial contrib, I was thining about a dependency, but I was not sure, if it is possible. How can it be done in the build.xml of the contrib?
was (Author: thetaphi):
Hi Patrick,
as the search contrib was included into Lucene after 2.4 where the old API is already deprecated, there is no need to implement bits() at all. Just leave the default, that get removed on 3.0. As the code was not released before the deprecation, there would be nobody using it and it does not make sense to add APIs that are deprecated from the beginning.
TrieRangeFilter was also included after the change and never implemented bits() [it implemented it in the past, but at this time it was in another package outside of lucene, so deprecation is out of responsibility for lucene].
Paul:
bq. In case you prefer to use one of these, a dependency on the corresponding contrib module may have to be added in the build process of the spatial contrib.
Very interesting, on thinking about how to include TrieRangeQuery with spatial contrib, I was thining about a dependency, but I was not sure, if it is possible. How can it be done in the build.xml of the contrib?
> SerialChainFilter should use DocSet API rather then deprecated BitSet API
> -------------------------------------------------------------------------
>
> Key: LUCENE-1504
> URL: https://issues.apache.org/jira/browse/LUCENE-1504
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/spatial
> Reporter: Ryan McKinley
> Fix For: 2.9
>
> Attachments: LUCENE-1504.patch
>
>
> From erik's comments in LUCENE-1387
> * Maybe the Filter's should be using the DocIdSet API rather than the BitSet deprecated stuff? We can refactor that after being committed I supposed, but not something we want to leave like that.
> We should also look at moving SerialChainFilter out of the spatial contrib since it is more generally useful then just spatial search.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org