You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/05/20 14:36:45 UTC
[GitHub] [geode] jdeppe-pivotal opened a new pull request #5140: GEODE-8151: Convert hash commands to return RedisResponse
jdeppe-pivotal opened a new pull request #5140:
URL: https://github.com/apache/geode/pull/5140
- Convert hash tests to use assertj
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal merged pull request #5140: GEODE-8151: Convert hash commands to return RedisResponse
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal merged pull request #5140:
URL: https://github.com/apache/geode/pull/5140
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5140: GEODE-8151: Convert hash commands to return RedisResponse
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on a change in pull request #5140:
URL: https://github.com/apache/geode/pull/5140#discussion_r428425213
##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/hash/HScanExecutor.java
##########
@@ -95,28 +94,24 @@ public void executeCommand(Command command, ExecutionHandlerContext context) {
count = Coder.bytesToInt(bytes);
}
} catch (NumberFormatException e) {
- command.setResponse(Coder.getErrorResponse(context.getByteBufAllocator(), ERROR_COUNT));
- return;
+ return RedisResponse.error(ERROR_COUNT);
}
}
if (count < 0) {
- command.setResponse(Coder.getErrorResponse(context.getByteBufAllocator(), ERROR_COUNT));
- return;
+ return RedisResponse.error(ERROR_COUNT);
}
try {
matchPattern = convertGlobToRegex(globMatchPattern);
} catch (PatternSyntaxException e) {
- command.setResponse(
- Coder.getErrorResponse(context.getByteBufAllocator(), RedisConstants.ERROR_ILLEGAL_GLOB));
- return;
+ return RedisResponse.error(RedisConstants.ERROR_ILLEGAL_GLOB);
Review comment:
a static import of ERROR_ILLEGAL_GLOB would be nice
##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/hash/HExistsExecutor.java
##########
@@ -53,12 +54,7 @@ public void executeCommand(Command command, ExecutionHandlerContext context) {
RedisHash map = getRedisHash(context, key);
boolean hasField = map.containsKey(field);
- if (hasField) {
- command.setResponse(Coder.getIntegerResponse(context.getByteBufAllocator(), EXISTS));
- } else {
- command.setResponse(Coder.getIntegerResponse(context.getByteBufAllocator(), NOT_EXISTS));
- }
-
+ return RedisResponse.integer(hasField ? EXISTS : NOT_EXISTS);
Review comment:
What do you think of supporting a flavor of "integer(boolean)" that would respond with 1 if true and 0 if false? I've seen a large number of redis commands that do this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5140: GEODE-8151: Convert hash commands to return RedisResponse
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on a change in pull request #5140:
URL: https://github.com/apache/geode/pull/5140#discussion_r429265420
##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/hash/HExistsExecutor.java
##########
@@ -53,12 +54,7 @@ public void executeCommand(Command command, ExecutionHandlerContext context) {
RedisHash map = getRedisHash(context, key);
boolean hasField = map.containsKey(field);
- if (hasField) {
- command.setResponse(Coder.getIntegerResponse(context.getByteBufAllocator(), EXISTS));
- } else {
- command.setResponse(Coder.getIntegerResponse(context.getByteBufAllocator(), NOT_EXISTS));
- }
-
+ return RedisResponse.integer(hasField ? EXISTS : NOT_EXISTS);
Review comment:
Yes, good idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org