You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/05/01 00:40:43 UTC

[GitHub] mistercrunch opened a new pull request #4910: Use React.PureComponent everywhere

mistercrunch opened a new pull request #4910: Use React.PureComponent everywhere
URL: https://github.com/apache/incubator-superset/pull/4910
 
 
   s/React.Component/React.PureComponent/g
   
   Did a bit of manual testing but I think we've had good hygiene of not mutating props. This should result in much less rendering.
   
   @graceguo-supercat @williaster what do you all think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services