You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/01/15 07:08:07 UTC
[GitHub] [hbase] saintstack opened a new pull request #1044: HBASE-23690
Checkstyle plugin complains about our checkstyle.xml format
saintstack opened a new pull request #1044: HBASE-23690 Checkstyle plugin complains about our checkstyle.xml format
URL: https://github.com/apache/hbase/pull/1044
This works but not sure if it generally good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1044: HBASE-23690
Checkstyle plugin complains about our checkstyle.xml format
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1044: HBASE-23690 Checkstyle plugin complains about our checkstyle.xml format
URL: https://github.com/apache/hbase/pull/1044#issuecomment-574758839
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 44s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 49s | master passed |
| +0 :ok: | refguide | 6m 58s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 50s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +0 :ok: | refguide | 6m 56s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 20s | The patch does not generate ASF License warnings. |
| | | 28m 52s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1044/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1044 |
| Optional Tests | dupname asflicense refguide |
| uname | Linux 0b638f2b3c22 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1044/out/precommit/personality/provided.sh |
| git revision | master / cb78b103a7 |
| refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1044/2/artifact/out/branch-site/book.html |
| refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1044/2/artifact/out/patch-site/book.html |
| Max. process+thread count | 96 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1044/2/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on issue #1044: HBASE-23690 Checkstyle
plugin complains about our checkstyle.xml format
Posted by GitBox <gi...@apache.org>.
saintstack commented on issue #1044: HBASE-23690 Checkstyle plugin complains about our checkstyle.xml format
URL: https://github.com/apache/hbase/pull/1044#issuecomment-574740857
Made this a doc change only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on issue #1044: HBASE-23690 Checkstyle
plugin complains about our checkstyle.xml format
Posted by GitBox <gi...@apache.org>.
busbey commented on issue #1044: HBASE-23690 Checkstyle plugin complains about our checkstyle.xml format
URL: https://github.com/apache/hbase/pull/1044#issuecomment-574639599
-1 do not merge as is. Please see @bharathv's comments about checkstyle plugin version.
You wanna take the plunge updating the plugin?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack merged pull request #1044: HBASE-23690
Checkstyle plugin complains about our checkstyle.xml format
Posted by GitBox <gi...@apache.org>.
saintstack merged pull request #1044: HBASE-23690 Checkstyle plugin complains about our checkstyle.xml format
URL: https://github.com/apache/hbase/pull/1044
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on issue #1044: HBASE-23690 Checkstyle
plugin complains about our checkstyle.xml format
Posted by GitBox <gi...@apache.org>.
saintstack commented on issue #1044: HBASE-23690 Checkstyle plugin complains about our checkstyle.xml format
URL: https://github.com/apache/hbase/pull/1044#issuecomment-574713641
Closing in favor of @bharathv HBASE-23242
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1044: HBASE-23690
Checkstyle plugin complains about our checkstyle.xml format
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1044: HBASE-23690 Checkstyle plugin complains about our checkstyle.xml format
URL: https://github.com/apache/hbase/pull/1044#issuecomment-574531455
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 1s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 24s | master passed |
| +1 :green_heart: | checkstyle | 2m 35s | master passed |
| +1 :green_heart: | javadoc | 0m 15s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 57s | the patch passed |
| -1 :x: | checkstyle | 0m 12s | The patch fails to run checkstyle in root |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 13s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 14s | hbase-checkstyle in the patch passed. |
| +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. |
| | | 15m 49s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1044/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1044 |
| Optional Tests | dupname asflicense checkstyle javac javadoc unit xml |
| uname | Linux ee90e9d8998c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1044/out/precommit/personality/provided.sh |
| git revision | master / a075d6a011 |
| Default Java | 1.8.0_181 |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1044/1/artifact/out//home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1044/out/maven-patch-checkstyle-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1044/1/testReport/ |
| Max. process+thread count | 96 (vs. ulimit of 10000) |
| modules | C: hbase-checkstyle U: hbase-checkstyle |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1044/1/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services